Resolve NuGet Audit errors in VMR builds#546
Conversation
fc13430 to
6e30ad3
Compare
I think this means that Lines 48 to 50 in b60c10b |
The imports happen in the init-source-build phase before the PSB tarball is extracted therefore the PSB.versions.props doesn't get applied. Possible solutions:
|
|
Thanks. I just pushed a commit that fixes that. The sequence was already correct (the msbuildsdkresolver evaluates, restores and builds after the PSB archive is extracted) but there was an import mistake. The |
|
The non-source-build jobs should be unblocked now but source-build ones need an update to use PSB to avoid prebuilts. |
...tNet.UnifiedBuild.MSBuildSdkResolver/Microsoft.DotNet.UnifiedBuild.MSBuildSdkResolver.csproj
Show resolved
Hide resolved
...tNet.UnifiedBuild.MSBuildSdkResolver/Microsoft.DotNet.UnifiedBuild.MSBuildSdkResolver.csproj
Show resolved
Hide resolved
eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/Microsoft.DotNet.UnifiedBuild.Tasks.csproj
Show resolved
Hide resolved
|
@dotnet/source-build can you please help with the SB test failures? TIA |
Yes - @mthalman is already investigating. |
|
The SB leg is getting failures in the test step like the following: This is because it's picking up the PSB version but there's no PSB feed defined. |
|
Just to summarize, this change also discovered two regression that are getting fixed:
|
Fixes dotnet/source-build#5187