Skip to content

[main] Source code updates from dotnet/runtime#544

Merged
ViktorHofer merged 9 commits intomainfrom
darc-main-ae63917e-be8e-4837-a684-f12d06326374
May 16, 2025
Merged

[main] Source code updates from dotnet/runtime#544
ViktorHofer merged 9 commits intomainfrom
darc-main-ae63917e-be8e-4837-a684-f12d06326374

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented May 14, 2025

Note

This is a codeflow update. It may contain both source code changes from the source repo as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/runtime

@ViktorHofer
Copy link
Member

[xUnit.net 00:02:40.52]     Microsoft.DotNet.SourceBuild.Tests.WebScenarioTests.VerifyScenario(scenario: TestScenario { Commands = Build | Run | Publish, Language = CSharp, NoHttps = False, ScenarioName = "WebScenarioTests", Template = BlazorWasm, ··· }) [FAIL]
[xUnit.net 00:02:40.52]       System.InvalidOperationException : Failed to execute /__w/1/s/artifacts/obj/extracted-dotnet-sdk/dotnet build /p:RestoreAdditionalProjectSources= /bl:/__w/1/s/artifacts/TestResults/Release/WebScenarioTests_BlazorWasm_CSharp-build.binlog
[xUnit.net 00:02:40.52]       Exit code: 1
[xUnit.net 00:02:40.52]       Determining projects to restore...
[xUnit.net 00:02:40.52]       /__w/1/s/artifacts/bin/Microsoft.DotNet.SourceBuild.Tests/Release/projects-202505140519528562/WebScenarioTests_BlazorWasm_CSharp/WebScenarioTests_BlazorWasm_CSharp.csproj : warning NU1603: WebScenarioTests_BlazorWasm_CSharp depends on Microsoft.NET.Sdk.WebAssembly.Pack (>= 10.0.0-preview.5.25263.9) but Microsoft.NET.Sdk.WebAssembly.Pack 10.0.0-preview.5.25263.9 was not found. Microsoft.NET.Sdk.WebAssembly.Pack 10.0.0-preview.5.25263.102 was resolved instead.
[xUnit.net 00:02:40.52]       /__w/1/s/artifacts/bin/Microsoft.DotNet.SourceBuild.Tests/Release/projects-202505140519528562/WebScenarioTests_BlazorWasm_CSharp/WebScenarioTests_BlazorWasm_CSharp.csproj : error NU1102: Unable to find package Microsoft.NETCore.App.Runtime.Mono.browser-wasm with version (= 10.0.0-preview.5.25263.9)
[xUnit.net 00:02:40.52]       /__w/1/s/artifacts/bin/Microsoft.DotNet.SourceBuild.Tests/Release/projects-202505140519528562/WebScenarioTests_BlazorWasm_CSharp/WebScenarioTests_BlazorWasm_CSharp.csproj : error NU1102:   - Found 1417 version(s) in dotnet9 [ Nearest version: 9.0.0-rtm.24516.5 ]
[xUnit.net 00:02:40.52]       /__w/1/s/artifacts/bin/Microsoft.DotNet.SourceBuild.Tests/Release/projects-202505140519528562/WebScenarioTests_BlazorWasm_CSharp/WebScenarioTests_BlazorWasm_CSharp.csproj : error NU1102:   - Found 1169 version(s) in dotnet10 [ Nearest version: 10.0.0-preview.5.25263.102 ]
[xUnit.net 00:02:40.52]       /__w/1/s/artifacts/bin/Microsoft.DotNet.SourceBuild.Tests/Release/projects-202505140519528562/WebScenarioTests_BlazorWasm_CSharp/WebScenarioTests_BlazorWasm_CSharp.csproj : error NU1102:   - Found 116 version(s) in dotnet-public [ Nearest version: 10.0.0-preview.4.25258.110 ]
[xUnit.net 00:02:40.52]       /__w/1/s/artifacts/bin/Microsoft.DotNet.SourceBuild.Tests/Release/projects-202505140519528562/WebScenarioTests_BlazorWasm_CSharp/WebScenarioTests_BlazorWasm_CSharp.csproj : error NU1102:   - Found 0 version(s) in /__w/1/s/artifacts/obj/extracted-dotnet-sdk/library-packs
[xUnit.net 00:02:40.52]       /__w/1/s/artifacts/bin/Microsoft.DotNet.SourceBuild.Tests/Release/projects-202505140519528562/WebScenarioTests_BlazorWasm_CSharp/WebScenarioTests_BlazorWasm_CSharp.csproj : error NU1102:   - Found 0 version(s) in darc-pub-dotnet-aspnetcore-3cc83de
[xUnit.net 00:02:40.52]       /__w/1/s/artifacts/bin/Microsoft.DotNet.SourceBuild.Tests/Release/projects-202505140519528562/WebScenarioTests_BlazorWasm_CSharp/WebScenarioTests_BlazorWasm_CSharp.csproj : error NU1102:   - Found 0 version(s) in darc-pub-dotnet-runtime-d398172
[xUnit.net 00:02:40.52]       /__w/1/s/artifacts/bin/Microsoft.DotNet.SourceBuild.Tests/Release/projects-202505140519528562/WebScenarioTests_BlazorWasm_CSharp/WebScenarioTests_BlazorWasm_CSharp.csproj : error NU1102:   - Found 0 version(s) in dotnet10-transport
[xUnit.net 00:02:40.52]       /__w/1/s/artifacts/bin/Microsoft.DotNet.SourceBuild.Tests/Release/projects-202505140519528562/WebScenarioTests_BlazorWasm_CSharp/WebScenarioTests_BlazorWasm_CSharp.csproj : error NU1102:   - Found 0 version(s) in dotnet9-transport
[xUnit.net 00:02:40.52]         Failed to restore /__w/1/s/artifacts/bin/Microsoft.DotNet.SourceBuild.Tests/Release/projects-202505140519528562/WebScenarioTests_BlazorWasm_CSharp/WebScenarioTests_BlazorWasm_CSharp.csproj (in 774 ms).

@jkoritzinsky I think this is due to the runtime official build not producing artifacts anymore but source-build tests still relying on them. Not 100% sure. cc @dotnet/source-build

@akoeplinger
Copy link
Member

akoeplinger commented May 14, 2025

Yes we hit the same in the Microsoft build and disabled these tests that rely on outputs from other verticals there, see dotnet/sdk#47108 and

<ScenarioTestsAdditionalArgs Condition="'$(DotNetBuildPass)' == '' or '$(DotNetBuildPass)' == '1'">$(ScenarioTestsAdditionalArgs) --no-traits Category=RequiresNonTargetRidPackages</ScenarioTestsAdditionalArgs>

@jkoritzinsky
Copy link
Member

Yes this looks like it's dependent on the Microsoft build bits. I believe this is being addressed in part by #515 and should be fixed by #400?

@jkoritzinsky
Copy link
Member

/azp run dotnet-unified-build

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

338 file changes from runtime + 2 in the VMR. LGTM

@ViktorHofer ViktorHofer enabled auto-merge (squash) May 15, 2025 07:50
@ViktorHofer
Copy link
Member

 /__w/1/s/src/source-build-reference-packages/src/targetPacks/Directory.Build.targets(57,5): error : /__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/microsoft.netcore.app.ref/6.0.0/ref/net6.0/System.Transactions.Local.il(784) : error : syntax error at token 'async' in:                                int32 async) cil managed [/__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/microsoft.netcore.app.ref/6.0.0/Microsoft.NETCore.App.Ref.6.0.0.csproj]
  /__w/1/s/src/source-build-reference-packages/src/targetPacks/Directory.Build.targets(57,5): error MSB3073: The command "/__w/1/s/src/source-build-reference-packages/src/targetPacks/build-il.sh /__w/1/s/src/source-build-reference-packages/artifacts/.packages/runtime.centos.9-x64.microsoft.netcore.ilasm/10.0.0-preview.5.99631.199/runtimes/centos.9-x64/native/ /__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/microsoft.netcore.app.ref/6.0.0/ref/net6.0/System.Transactions.Local.il /__w/1/s/src/source-build-reference-packages/artifacts/bin/Microsoft.NETCore.App.Ref.6.0.0/pack/ref/net6.0/System.Transactions.Local.dll" exited with code 1. [/__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/microsoft.netcore.app.ref/6.0.0/Microsoft.NETCore.App.Ref.6.0.0.csproj]
  /__w/1/s/src/source-build-reference-packages/src/targetPacks/Directory.Build.targets(57,5): error : /__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/microsoft.netcore.app.ref/7.0.0/ref/net7.0/System.Transactions.Local.il(810) : error : syntax error at token 'async' in:                                int32 async) cil managed [/__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/microsoft.netcore.app.ref/7.0.0/Microsoft.NETCore.App.Ref.7.0.0.csproj]
  /__w/1/s/src/source-build-reference-packages/src/targetPacks/Directory.Build.targets(57,5): error MSB3073: The command "/__w/1/s/src/source-build-reference-packages/src/targetPacks/build-il.sh /__w/1/s/src/source-build-reference-packages/artifacts/.packages/runtime.centos.9-x64.microsoft.netcore.ilasm/10.0.0-preview.5.99631.199/runtimes/centos.9-x64/native/ /__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/microsoft.netcore.app.ref/7.0.0/ref/net7.0/System.Transactions.Local.il /__w/1/s/src/source-build-reference-packages/artifacts/bin/Microsoft.NETCore.App.Ref.7.0.0/pack/ref/net7.0/System.Transactions.Local.dll" exited with code 1. [/__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/microsoft.netcore.app.ref/7.0.0/Microsoft.NETCore.App.Ref.7.0.0.csproj]
  /__w/1/s/src/source-build-reference-packages/src/targetPacks/Directory.Build.targets(57,5): error : /__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/microsoft.netcore.app.ref/8.0.0/ref/net8.0/System.Transactions.Local.il(659) : error : syntax error at token 'async' in:                                int32 async) cil managed [/__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/microsoft.netcore.app.ref/8.0.0/Microsoft.NETCore.App.Ref.8.0.0.csproj]
  /__w/1/s/src/source-build-reference-packages/src/targetPacks/Directory.Build.targets(57,5): error MSB3073: The command "/__w/1/s/src/source-build-reference-packages/src/targetPacks/build-il.sh /__w/1/s/src/source-build-reference-packages/artifacts/.packages/runtime.centos.9-x64.microsoft.netcore.ilasm/10.0.0-preview.5.99631.199/runtimes/centos.9-x64/native/ /__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/microsoft.netcore.app.ref/8.0.0/ref/net8.0/System.Transactions.Local.il /__w/1/s/src/source-build-reference-packages/artifacts/bin/Microsoft.NETCore.App.Ref.8.0.0/pack/ref/net8.0/System.Transactions.Local.dll" exited with code 1. [/__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/microsoft.netcore.app.ref/8.0.0/Microsoft.NETCore.App.Ref.8.0.0.csproj]
  /__w/1/s/src/source-build-reference-packages/src/targetPacks/Directory.Build.targets(57,5): error : /__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/microsoft.netcore.app.ref/9.0.0/ref/net9.0/System.Transactions.Local.il(659) : error : syntax error at token 'async' in:                                int32 async) cil managed [/__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/microsoft.netcore.app.ref/9.0.0/Microsoft.NETCore.App.Ref.9.0.0.csproj]
  /__w/1/s/src/source-build-reference-packages/src/targetPacks/Directory.Build.targets(57,5): error MSB3073: The command "/__w/1/s/src/source-build-reference-packages/src/targetPacks/build-il.sh /__w/1/s/src/source-build-reference-packages/artifacts/.packages/runtime.centos.9-x64.microsoft.netcore.ilasm/10.0.0-preview.5.99631.199/runtimes/centos.9-x64/native/ /__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/microsoft.netcore.app.ref/9.0.0/ref/net9.0/System.Transactions.Local.il /__w/1/s/src/source-build-reference-packages/artifacts/bin/Microsoft.NETCore.App.Ref.9.0.0/pack/ref/net9.0/System.Transactions.Local.dll" exited with code 1. [/__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/microsoft.netcore.app.ref/9.0.0/Microsoft.NETCore.App.Ref.9.0.0.csproj]
  /__w/1/s/src/source-build-reference-packages/src/targetPacks/Directory.Build.targets(57,5): error : /__w/1/s/src/source-build-reference-packages/artifacts/obj/NETStandard.Library.Ref.2.1.0/Release/netstandard2.0/ref/netstandard2.1/netstandard.patched.il(98028) : error : syntax error at token 'async' in:                                int32 async) cil managed [/__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/netstandard.library.ref/2.1.0/NETStandard.Library.Ref.2.1.0.csproj]
  /__w/1/s/src/source-build-reference-packages/src/targetPacks/Directory.Build.targets(57,5): error MSB3073: The command "/__w/1/s/src/source-build-reference-packages/src/targetPacks/build-il.sh /__w/1/s/src/source-build-reference-packages/artifacts/.packages/runtime.centos.9-x64.microsoft.netcore.ilasm/10.0.0-preview.5.99631.199/runtimes/centos.9-x64/native/ /__w/1/s/src/source-build-reference-packages/artifacts/obj/NETStandard.Library.Ref.2.1.0/Release/netstandard2.0/ref/netstandard2.1/netstandard.patched.il /__w/1/s/src/source-build-reference-packages/artifacts/bin/NETStandard.Library.Ref.2.1.0/pack/ref/netstandard2.1/netstandard.dll" exited with code 1. [/__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/netstandard.library.ref/2.1.0/NETStandard.Library.Ref.2.1.0.csproj]
  /__w/1/s/src/source-build-reference-packages/src/targetPacks/Directory.Build.targets(57,5): error : /__w/1/s/src/source-build-reference-packages/artifacts/obj/NETStandard.Library.2.0.3/Release/netstandard2.0/build/netstandard2.0/ref/netstandard.patched.il(50683) : error : syntax error at token 'async' in:                                int32 async) cil managed [/__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/netstandard.library/2.0.3/NETStandard.Library.2.0.3.csproj]
  /__w/1/s/src/source-build-reference-packages/src/targetPacks/Directory.Build.targets(57,5): error MSB3073: The command "/__w/1/s/src/source-build-reference-packages/src/targetPacks/build-il.sh /__w/1/s/src/source-build-reference-packages/artifacts/.packages/runtime.centos.9-x64.microsoft.netcore.ilasm/10.0.0-preview.5.99631.199/runtimes/centos.9-x64/native/ /__w/1/s/src/source-build-reference-packages/artifacts/obj/NETStandard.Library.2.0.3/Release/netstandard2.0/build/netstandard2.0/ref/netstandard.patched.il /__w/1/s/src/source-build-reference-packages/artifacts/bin/NETStandard.Library.2.0.3/pack/build/netstandard2.0/ref/netstandard.dll" exited with code 1. [/__w/1/s/src/source-build-reference-packages/src/targetPacks/ILsrc/netstandard.library/2.0.3/NETStandard.Library.2.0.3.csproj]

@jeffschwMSFT looks like an ILAsm regression (which dotnet/source-build-reference-packages uses to build checked-in .il files).

@jeffschwMSFT
Copy link
Member

@JulieLeeMSFT can you take a look? has ilasm changed recently? or is this hand crafted IL?

@ViktorHofer
Copy link
Member

Here's one of the lines that cause the errors in the checked-in IL:

Here's the commit diff: dotnet/runtime@d2c5618...c7c961a

dotnet/runtime@660f22a sounds related. cc @VSadov @jkotas

@jkotas
Copy link
Member

jkotas commented May 15, 2025

Yes, it is a regression introduce by that change. Reverting in dotnet/runtime#115621

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

425 file changes in runtime + 2 file changes in the VMR. LGTM

@ViktorHofer
Copy link
Member

artifacts\source-built-sdks\Microsoft.DotNet.SharedFramework.Sdk\targets\sharedfx.targets(493,5): error : (NETCORE_ENGINEERING_TELEMETRY=Build) Assembly 'System.Diagnostics.EventLog' is missing dependency 'System.Threading.AccessControl'

Regressed with dotnet/runtime@81f1f5e. @ericstj please take a look

@ViktorHofer
Copy link
Member

What I know so far:

  • System.Threading.AccessControl is part of the Microsoft.Internal.Runtime.AspNetCore.Transport package produced in that vertical ✅
  • The live property version is correctly overriden in aspnetcore with PvP flow ✅

@ViktorHofer
Copy link
Member

OK should hopefully be resolved now. I didn't know that aspnetcore still hand picks the runtime packages to include into their sfx.

@ViktorHofer
Copy link
Member

The source-build test now failed three times in a row. Seems to be deterministic and caused by this insertion.

[xUnit.net 00:00:21.89]     Microsoft.DotNet.SourceBuild.Tests.WebScenarioTests.VerifyScenario(scenario: TestScenario { Commands = Build | Run | Publish, Language = CSharp, NoHttps = False, ScenarioName = "WebScenarioTests", Template = Razor, ··· }) [FAIL]
[xUnit.net 00:00:21.89]       System.InvalidOperationException : Failed to execute /__w/1/s/artifacts/obj/extracted-dotnet-sdk/dotnet run --no-launch-profile /bl:/__w/1/s/artifacts/TestResults/Release/WebScenarioTests_Razor_CSharp-run.binlog
[xUnit.net 00:00:21.89]       Exit code: 143
[xUnit.net 00:00:21.89]       warn: Microsoft.AspNetCore.DataProtection.KeyManagement.XmlKeyManager[35]
[xUnit.net 00:00:21.89]             No XML encryptor configured. Key {654e999a-3579-4e10-aff0-c4bcdf4fb0b1} may be persisted to storage in unencrypted form.
[xUnit.net 00:00:21.89]       info: Microsoft.Hosting.Lifetime[14]
[xUnit.net 00:00:21.89]             Now listening on: http://[::]:41129/
[xUnit.net 00:00:21.89]       info: Microsoft.Hosting.Lifetime[0]
[xUnit.net 00:00:21.89]             Application started. Press Ctrl+C to shut down.
[xUnit.net 00:00:21.89]       info: Microsoft.Hosting.Lifetime[0]
[xUnit.net 00:00:21.89]             Hosting environment: Production
[xUnit.net 00:00:21.89]       info: Microsoft.Hosting.Lifetime[0]
[xUnit.net 00:00:21.89]             Content root path: /__w/1/s/artifacts/bin/Microsoft.DotNet.SourceBuild.Tests/Release/projects-202505161256524407/WebScenarioTests_Razor_CSharp
[xUnit.net 00:00:21.89]       warn: Microsoft.AspNetCore.HttpsPolicy.HttpsRedirectionMiddleware[3]
[xUnit.net 00:00:21.89]             Failed to determine the https port for redirect.
[xUnit.net 00:00:21.89]       
[xUnit.net 00:00:21.89]       Stack Trace:
[xUnit.net 00:00:21.89]         /_/test/TestUtilities/ExecuteHelper.cs(131,0): at TestUtilities.ExecuteHelper.ValidateExitCode(ValueTuple`3 result, Int32 expectedExitCode, String additionalOutput)
[xUnit.net 00:00:21.89]         /_/test/Microsoft.DotNet.SourceBuild.Tests/DotNetHelper.cs(85,0): at Microsoft.DotNet.SourceBuild.Tests.DotNetHelper.ExecuteCmd(String args, String workingDirectory, Action`1 processConfigCallback, Nullable`1 expectedExitCode, Int32 millisecondTimeout)
[xUnit.net 00:00:21.89]         /_/test/Microsoft.DotNet.SourceBuild.Tests/DotNetHelper.cs(216,0): at Microsoft.DotNet.SourceBuild.Tests.DotNetHelper.ExecuteWeb(String projectName, String args, String workingDirectory, DotNetTemplate template, Int32 expectedExitCode)
[xUnit.net 00:00:21.89]         /_/test/Microsoft.DotNet.SourceBuild.Tests/DotNetHelper.cs(199,0): at Microsoft.DotNet.SourceBuild.Tests.DotNetHelper.ExecuteRunWeb(String projectName, DotNetTemplate template)
[xUnit.net 00:00:21.89]         /_/test/Microsoft.DotNet.SourceBuild.Tests/TestScenario.cs(43,0): at Microsoft.DotNet.SourceBuild.Tests.TestScenario.Execute(DotNetHelper dotNetHelper)
[xUnit.net 00:00:21.89]         /_/test/Microsoft.DotNet.SourceBuild.Tests/WebScenarioTests.cs(26,0): at Microsoft.DotNet.SourceBuild.Tests.WebScenarioTests.VerifyScenario(TestScenario scenario)
[xUnit.net 00:00:21.89]            at System.Reflection.MethodBaseInvoker.InterpretedInvoke_Method(Object obj, IntPtr* args)
[xUnit.net 00:00:21.89]            at System.Reflection.MethodBaseInvoker.InvokeDirectByRefWithFewArgs(Object obj, Span`1 copyOfArgs, BindingFlags invokeAttr)
[xUnit.net 00:00:21.89]       Output:
[xUnit.net 00:00:21.89]         Executing: /__w/1/s/artifacts/obj/extracted-dotnet-sdk/dotnet new razor --name WebScenarioTests_Razor_CSharp --output /__w/1/s/artifacts/bin/Microsoft.DotNet.SourceBuild.Tests/Release/projects-202505161256524407/WebScenarioTests_Razor_CSharp --language "C#" 
[xUnit.net 00:00:21.89]         Executing: /__w/1/s/artifacts/obj/extracted-dotnet-sdk/dotnet build /p:RestoreAdditionalProjectSources= /bl:/__w/1/s/artifacts/TestResults/Release/WebScenarioTests_Razor_CSharp-build.binlog
[xUnit.net 00:00:21.89]         Executing: /__w/1/s/artifacts/obj/extracted-dotnet-sdk/dotnet run --no-launch-profile /bl:/__w/1/s/artifacts/TestResults/Release/WebScenarioTests_Razor_CSharp-run.binlog
[xUnit.net 00:00:21.89]         Detected app has started. Sending web request to validate...
[xUnit.net 00:00:21.89]         Status code returned: OK
[xUnit.net 00:00:21.89]         Executing: kill -s TERM 147540

@jkotas
Copy link
Member

jkotas commented May 16, 2025

The source-build test now failed three times in a row.

I will take care of this one. It is expected behavior change from dotnet/runtime#115494

@jkotas jkotas requested review from a team as code owners May 16, 2025 14:12
@jkotas
Copy link
Member

jkotas commented May 16, 2025

This is failing with nuget errors now:
src/roslyn/src/RoslynAnalyzers/Microsoft.CodeAnalysis.AnalyzerUtilities/Microsoft.CodeAnalysis.AnalyzerUtilities.csproj(0,0): error NU1109: (NETCORE_ENGINEERING_TELEMETRY=Restore) Detected package downgrade: System.Collections.Immutable from 10.0.0-preview.5.25265.101 to centrally defined 10.0.0-ci. Update the centrally managed package version to a higher version. Microsoft.CodeAnalysis.AnalyzerUtilities -> Microsoft.CodeAnalysis.Common 5.0.0-1.25265.101 -> System.Collections.Immutable (>= 10.0.0-preview.5.25265.101) Microsoft.CodeAnalysis.AnalyzerUtilities -> System.Collections.Immutable (>= 10.0.0-ci)

@mthalman
Copy link
Member

This is failing with nuget errors now: src/roslyn/src/RoslynAnalyzers/Microsoft.CodeAnalysis.AnalyzerUtilities/Microsoft.CodeAnalysis.AnalyzerUtilities.csproj(0,0): error NU1109: (NETCORE_ENGINEERING_TELEMETRY=Restore) Detected package downgrade: System.Collections.Immutable from 10.0.0-preview.5.25265.101 to centrally defined 10.0.0-ci. Update the centrally managed package version to a higher version. Microsoft.CodeAnalysis.AnalyzerUtilities -> Microsoft.CodeAnalysis.Common 5.0.0-1.25265.101 -> System.Collections.Immutable (>= 10.0.0-preview.5.25265.101) Microsoft.CodeAnalysis.AnalyzerUtilities -> System.Collections.Immutable (>= 10.0.0-ci)

I don't know why that pipeline run is happening. That is a known failure. But for these changes, you just need this run to pass: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1043623&view=results.

@ViktorHofer ViktorHofer merged commit 47a5e1c into main May 16, 2025
41 of 65 checks passed
@ViktorHofer ViktorHofer deleted the darc-main-ae63917e-be8e-4837-a684-f12d06326374 branch May 16, 2025 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants