[main] Source code updates from dotnet/runtime#544
Conversation
@jkoritzinsky I think this is due to the runtime official build not producing artifacts anymore but source-build tests still relying on them. Not 100% sure. cc @dotnet/source-build |
|
Yes we hit the same in the Microsoft build and disabled these tests that rely on outputs from other verticals there, see dotnet/sdk#47108 and dotnet/repo-projects/scenario-tests.proj Line 40 in b60c10b |
|
/azp run dotnet-unified-build |
|
Azure Pipelines successfully started running 1 pipeline(s). |
ViktorHofer
left a comment
There was a problem hiding this comment.
338 file changes from runtime + 2 in the VMR. LGTM
@jeffschwMSFT looks like an ILAsm regression (which dotnet/source-build-reference-packages uses to build checked-in .il files). |
|
@JulieLeeMSFT can you take a look? has ilasm changed recently? or is this hand crafted IL? |
|
Here's one of the lines that cause the errors in the checked-in IL: Here's the commit diff: dotnet/runtime@d2c5618...c7c961a dotnet/runtime@660f22a sounds related. cc @VSadov @jkotas |
|
Yes, it is a regression introduce by that change. Reverting in dotnet/runtime#115621 |
ViktorHofer
left a comment
There was a problem hiding this comment.
425 file changes in runtime + 2 file changes in the VMR. LGTM
Regressed with dotnet/runtime@81f1f5e. @ericstj please take a look |
|
What I know so far:
|
|
OK should hopefully be resolved now. I didn't know that aspnetcore still hand picks the runtime packages to include into their sfx. |
|
The source-build test now failed three times in a row. Seems to be deterministic and caused by this insertion. |
I will take care of this one. It is expected behavior change from dotnet/runtime#115494 |
Behavior change introduced by dotnet/runtime#115494
|
This is failing with nuget errors now: |
I don't know why that pipeline run is happening. That is a known failure. But for these changes, you just need this run to pass: https://dev.azure.com/dnceng-public/public/_build/results?buildId=1043623&view=results. |
Note
This is a codeflow update. It may contain both source code changes from the source repo as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/runtime