Skip to content

Re-Bootstrap Source Build to .NET 10.0.100-preview.5.25230.108 and use Unified-Build's SB legs for PR validation#515

Merged
MichaelSimons merged 10 commits intodotnet:mainfrom
ellahathaway:test
May 14, 2025
Merged

Re-Bootstrap Source Build to .NET 10.0.100-preview.5.25230.108 and use Unified-Build's SB legs for PR validation#515
MichaelSimons merged 10 commits intodotnet:mainfrom
ellahathaway:test

Conversation

@ellahathaway
Copy link
Member

No description provided.

@ellahathaway
Copy link
Member Author

The build ID that I initially set is getting overridden in the repo-builds:

./build.sh --ci --clean-while-building --prepareMachine -c Release --online --source-only /p:VerticalName=CentOSStream9_Online_MsftSdk_x64 /p:ArtifactsStagingDir=/__w/1/a -arch x64 /p:OfficialBuildId=20991231.99
...
src/source-build-reference-packages/eng/common/build.sh --restore --build --pack --publish --ci --configuration Release --verbosity minimal /p:TargetRid=centos.9-x64 /p:OfficialBuildId=20250508.1

@ellahathaway ellahathaway marked this pull request as ready for review May 13, 2025 17:05
@ellahathaway ellahathaway requested review from a team as code owners May 13, 2025 17:05
Copy link
Member

@MichaelSimons MichaelSimons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the [No Merge] prefix be removed from the PR title?

@ellahathaway ellahathaway changed the title [No merge] Test Unified-Build's SB validation with rebootstrap changes Re-Bootstrap Source Build to .NET 10.0.100-preview.5.25230.108 and use Unified-Build's SB legs for PR validation May 13, 2025
@ellahathaway
Copy link
Member Author

8 scenario tests are failing - I'm investigating

@mthalman
Copy link
Member

Oh, sure. This would be expected. We're in a funky configuration here because we're setting the official build ID but we also don't have access to all the Microsoft build artifacts that we would normally have in an official build. This will all get sorted out with my pipeline changes. I have changes that only include these failing tests to be run when it's an official build as we can't run them in PR builds. You could add temporary changes that would skip these tests for a PR build but that would just be temporary and get removed by my changes. @MichaelSimons - Thoughts on just disabling these failing tests entirely for now?

@MichaelSimons
Copy link
Member

Thoughts on just disabling these failing tests entirely for now?

That sounds like a reasonable plan to unblock.

@ellahathaway
Copy link
Member Author

Thoughts on just disabling these failing tests entirely for now?

That sounds like a reasonable plan to unblock.

Disabled the failing tests in 6f63092

@mthalman
Copy link
Member

There are some more tests that need to be disabled.

@mmitche
Copy link
Member

mmitche commented May 14, 2025

@ellahathaway @ViktorHofer @mthalman @MichaelSimons Do you think this is the right place to also do an update of the arcade global.json to the matching 10.0.100-preview.5.25230.108 SDK? My gut is saying yes.

@ellahathaway
Copy link
Member Author

Alright stage 1 is passing now! But stage 2 is failing to build the tests.

@mthalman
Copy link
Member

scenario-tests fails to build with this error:

/__w/1/s/.packages/tests/BootstrapPackages/microsoft.dotnet.arcade.sdk/10.0.0-beta.99631.199/tools/Tools.proj : error NU1102: Unable to find package Microsoft.DotNet.Build.Tasks.Feed with version (>= 10.0.0-beta.99631.199)
/__w/1/s/.packages/tests/BootstrapPackages/microsoft.dotnet.arcade.sdk/10.0.0-beta.99631.199/tools/Tools.proj : error NU1102:   - Found 1159 version(s) in dotnet-eng [ Nearest version: 10.0.0-beta.25263.104 ]
/__w/1/s/.packages/tests/BootstrapPackages/microsoft.dotnet.arcade.sdk/10.0.0-beta.99631.199/tools/Tools.proj : error NU1102:   - Found 0 version(s) in dotnet-libraries
/__w/1/s/.packages/tests/BootstrapPackages/microsoft.dotnet.arcade.sdk/10.0.0-beta.99631.199/tools/Tools.proj : error NU1102:   - Found 0 version(s) in dotnet-public

I ran into this same issue with #400. I'll add the fix here.

@MichaelSimons
Copy link
Member

@ellahathaway @ViktorHofer @mthalman @MichaelSimons Do you think this is the right place to also do an update of the arcade global.json to the matching 10.0.100-preview.5.25230.108 SDK? My gut is saying yes.

I think we should be updating it along with the VMR's eng/common as part of bootstrapping. I lean towards that we should get this in w/o additional changes to unblock folks and then circle around with another rebootstrap w/these additional changes.

@ellahathaway
Copy link
Member Author

ellahathaway commented May 14, 2025

Some legs are failing with the following NU1901 errors:

- error NU1901: (NETCORE_ENGINEERING_TELEMETRY=Restore) Package 'Microsoft.Build.Tasks.Core' 17.8.3 has a known low severity vulnerability
- error NU1901: (NETCORE_ENGINEERING_TELEMETRY=Restore) Package 'Microsoft.Build.Tasks.Core' 17.12.6 has a known low severity vulnerability

In one leg, the error did not occur on a retry of the build. What's odd is that NU1901 is included as a warning not to error on.

Also, the errors seem inconsistent, as some legs did not fail at the same place on retry.

@MichaelSimons
Copy link
Member

Some legs are failing with the following NU1901 errors:

This is a known issue - see #546

@ellahathaway
Copy link
Member Author

Some legs are failing with the following NU1901 errors:

This is a known issue - see #546

Thoughts on merging this on red then? The SB legs are passing, and the UB legs were passing before the nuget audit warnings hit.

@ViktorHofer
Copy link
Member

The SB leg is still failing, isn't it?

@MichaelSimons
Copy link
Member

The SB leg is still failing, isn't it?

This is the old SB PR validation leg. It is being replaced in this PR by the UB SB PR leg. Once merged I will removed the old dotnet-source-build as a required check.

@ellahathaway ellahathaway disabled auto-merge May 14, 2025 15:53
@MichaelSimons MichaelSimons merged commit 3a45201 into dotnet:main May 14, 2025
6 of 12 checks passed
@ellahathaway ellahathaway deleted the test branch May 14, 2025 15:53
@mthalman
Copy link
Member

The SB legs are passing, and the UB legs were passing before the nuget audit warnings hit.

Well, stage 1 was passing. We never got a chance to see if my fix got stage 2 to pass.

@ellahathaway
Copy link
Member Author

The SB legs are passing, and the UB legs were passing before the nuget audit warnings hit.

Well, stage 1 was passing. We never got a chance to see if my fix got stage 2 to pass.

Your fix was included in https://dev.azure.com/dnceng-public/public/_build/results?buildId=1041355&view=results, which shows that stage 2 was passing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants