[main] Source code updates from dotnet/runtime by dotnet-maestro[bot] · Pull Request #4727 · dotnet/dotnet

dotnet-maestro · 2026-02-09T02:05:15Z

Note

This is a codeflow update. It may contain both source code changes from
the source repo
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/runtime

Subscription: 6458ae35-db00-43d0-af59-e57a01ca3120
Build: 20260210.16 (301220)
Date Produced: February 10, 2026 10:54:26 PM UTC
Commit: 0b91113ce10b7b868f0df88a1c87ae8f2f04bbf0
Commit Diff: 18a3069...0b91113
Branch: main

Diff the source with this PR branch

darc vmr diff --name-only https://github.com/dotnet/runtime:0b91113ce10b7b868f0df88a1c87ae8f2f04bbf0..https://github.com/dotnet/dotnet:darc-main-0d46b718-7792-4b8c-b50c-8f9b703de37e

Diff: https://github.com/dotnet/runtime/compare/18a3069ebfd2f1c1c07c5cb567e4714999e81e61..7c40af1e61152073cace7b33c8afe2fc77a052dc From: dotnet/runtime@18a3069 To: dotnet/runtime@7c40af1 [[ commit created by automation ]]

dotnet-maestro · 2026-02-09T02:05:16Z

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

ViktorHofer · 2026-02-09T09:34:01Z

@steveisok the build with ninja by default und Linux and Mac needs a reaction here. Looks like the images don't have Ninja installed.

steveisok · 2026-02-09T13:35:48Z

@steveisok the build with ninja by default und Linux and Mac needs a reaction here. Looks like the images don't have Ninja installed.

dotnet/dotnet-buildtools-prereqs-docker#1587

ViktorHofer · 2026-02-09T13:43:02Z

What needs to be done for Mac?

steveisok · 2026-02-09T13:54:56Z

What needs to be done for Mac?

Is there a failure on the mac I'm not seeing?

ViktorHofer · 2026-02-09T14:15:53Z

The iossimulator job which uses macos is passing so apparently not. Does that job provide enough validation?

steveisok · 2026-02-09T14:53:07Z

The iossimulator job which uses macos is passing so apparently not. Does that job provide enough validation?

It'll check for ninja and fail, so yes.

ViktorHofer · 2026-02-09T15:15:07Z

I meant if we think that's sufficient given that we use another machine pool (arm64) internally. But we can find out post-merge.

Diff: https://github.com/dotnet/runtime/compare/7c40af1e61152073cace7b33c8afe2fc77a052dc..b7db56ad9a0eadb983a1f4ea2df350188d4db695 From: dotnet/runtime@7c40af1 To: dotnet/runtime@b7db56a [[ commit created by automation ]]

dotnet-maestro · 2026-02-10T02:55:23Z

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

akoeplinger · 2026-02-10T09:50:54Z

src/aspnetcore/src/HealthChecks/HealthChecks/src/DefaultHealthCheckService.cs(225,10): error SYSLIB1025: (NETCORE_ENGINEERING_TELEMETRY=Build) Multiple logging methods are using event name HealthCheckEnd in class Log (https://learn.microsoft.com/dotnet/fundamentals/syslib-diagnostics/syslib1025)
src/aspnetcore/src/HealthChecks/HealthChecks/src/DefaultHealthCheckService.cs(228,10): error SYSLIB1025: (NETCORE_ENGINEERING_TELEMETRY=Build) Multiple logging methods are using event name HealthCheckEnd in class Log (https://learn.microsoft.com/dotnet/fundamentals/syslib-diagnostics/syslib1025)

Most likely caused by dotnet/runtime#124077 but I don't understand why this even gets raised because the warning is suppressed in code:

dotnet/src/aspnetcore/src/HealthChecks/HealthChecks/src/DefaultHealthCheckService.cs

Lines 220 to 231 in f6d9ee8

    
           #pragma warning disable SYSLIB1006 
        
           #pragma warning disable SYSLIB1025 
        
                   [LoggerMessage(EventIds.HealthCheckEndId, LogLevel.Debug, HealthCheckEndText, EventName = EventIds.HealthCheckEndName)] 
        
                   private static partial void HealthCheckEndHealthy(ILogger logger, string HealthCheckName, HealthStatus HealthStatus, double ElapsedMilliseconds, string? HealthCheckDescription); 
        
                   [LoggerMessage(EventIds.HealthCheckEndId, LogLevel.Warning, HealthCheckEndText, EventName = EventIds.HealthCheckEndName)] 
        
                   private static partial void HealthCheckEndDegraded(ILogger logger, string HealthCheckName, HealthStatus HealthStatus, double ElapsedMilliseconds, string? HealthCheckDescription, Exception? exception); 
        
                   [LoggerMessage(EventIds.HealthCheckEndId, LogLevel.Error, HealthCheckEndText, EventName = EventIds.HealthCheckEndName)] 
        
                   private static partial void HealthCheckEndUnhealthy(ILogger logger, string HealthCheckName, HealthStatus HealthStatus, double ElapsedMilliseconds, string? HealthCheckDescription, Exception? exception); 
        
           #pragma warning restore SYSLIB1025 
        
           #pragma warning restore SYSLIB1006

akoeplinger · 2026-02-10T09:52:38Z

oh I see, the PR has a notice:

Pragma Suppression Behavioral Note
In the test .targets and .WithDiagnostics.cs files, the PR adds project-level for SYSLIB1002;SYSLIB1013;SYSLIB1018;8795 and 8795. This is because DiagnosticInfo.GetTrimmedLocation creates locations without SyntaxTree references, breaking #pragma warning disable matching. While this only affects the test project directly, the same DiagnosticInfo pattern is used in the production Roslyn 4.0 generator path, meaning end-users of the LoggerMessageGenerator will lose the ability to suppress diagnostics via #pragma directives. This is a behavioral regression. The existing System.Text.Json generator already has this limitation too, so the Logging source generator will start to have the same behavior as System.Text.Json.

Reaction to dotnet/runtime#124077

Diff: https://github.com/dotnet/runtime/compare/b7db56ad9a0eadb983a1f4ea2df350188d4db695..0b91113ce10b7b868f0df88a1c87ae8f2f04bbf0 From: dotnet/runtime@b7db56a To: dotnet/runtime@0b91113 [[ commit created by automation ]]

dotnet-maestro · 2026-02-11T02:10:53Z

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

dotnet-policy-service bot requested a review from a team February 9, 2026 02:05

dotnet-maestro bot added 2 commits February 10, 2026 02:55

Merge main into darc-main-0d46b718-7792-4b8c-b50c-8f9b703de37e

24c4ef6

akoeplinger mentioned this pull request Feb 10, 2026

Improve LoggerMessageGenerator and JsonSourceGenerator incrementality dotnet/runtime#124077

Merged

Suppress SYSLIB warnings in project files instead

647cdab

Reaction to dotnet/runtime#124077

dotnet-policy-service bot requested a review from a team February 10, 2026 15:14

dotnet-maestro bot added 2 commits February 11, 2026 02:10

Merge main into darc-main-0d46b718-7792-4b8c-b50c-8f9b703de37e

7e78149

ViktorHofer approved these changes Feb 11, 2026

View reviewed changes

ViktorHofer merged commit 87581bf into main Feb 11, 2026
16 checks passed

ViktorHofer deleted the darc-main-0d46b718-7792-4b8c-b50c-8f9b703de37e branch February 11, 2026 08:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[main] Source code updates from dotnet/runtime#4727

[main] Source code updates from dotnet/runtime#4727
ViktorHofer merged 6 commits intomainfrom
darc-main-0d46b718-7792-4b8c-b50c-8f9b703de37e

dotnet-maestro bot commented Feb 9, 2026 •

edited

Loading

Uh oh!

dotnet-maestro bot commented Feb 9, 2026

Uh oh!

ViktorHofer commented Feb 9, 2026

Uh oh!

steveisok commented Feb 9, 2026

Uh oh!

ViktorHofer commented Feb 9, 2026

Uh oh!

steveisok commented Feb 9, 2026

Uh oh!

ViktorHofer commented Feb 9, 2026

Uh oh!

steveisok commented Feb 9, 2026

Uh oh!

ViktorHofer commented Feb 9, 2026 •

edited

Loading

Uh oh!

dotnet-maestro bot commented Feb 10, 2026

Uh oh!

akoeplinger commented Feb 10, 2026

Uh oh!

akoeplinger commented Feb 10, 2026

Uh oh!

dotnet-maestro bot commented Feb 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

dotnet-maestro bot commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

From https://github.com/dotnet/runtime

Uh oh!

dotnet-maestro bot commented Feb 9, 2026

Uh oh!

ViktorHofer commented Feb 9, 2026

Uh oh!

steveisok commented Feb 9, 2026

Uh oh!

ViktorHofer commented Feb 9, 2026

Uh oh!

steveisok commented Feb 9, 2026

Uh oh!

ViktorHofer commented Feb 9, 2026

Uh oh!

steveisok commented Feb 9, 2026

Uh oh!

ViktorHofer commented Feb 9, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dotnet-maestro bot commented Feb 10, 2026

Uh oh!

akoeplinger commented Feb 10, 2026

Uh oh!

akoeplinger commented Feb 10, 2026

Uh oh!

dotnet-maestro bot commented Feb 11, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

dotnet-maestro bot commented Feb 9, 2026 •

edited

Loading

ViktorHofer commented Feb 9, 2026 •

edited

Loading