[main] Source code updates from dotnet/msbuild#4579
Merged
ViktorHofer merged 10 commits intoFeb 6, 2026
Conversation
Contributor
Author
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Contributor
Author
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Contributor
Author
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Member
|
@rainersigwald looks like dotnet/msbuild#13157 - more specifically the nullability change in SdkResolver.cs requires a reaction in sdk. PTAL |
rainersigwald
added a commit
to rainersigwald/msbuild
that referenced
this pull request
Feb 4, 2026
The doc comment explicitly mentions returning null and the SDK can do so, which caused a break in dotnet/dotnet#4579: src\sdk\src\Resolvers\Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver\WorkloadSdkResolver.cs(35,36): error CS8764: Nullability of return type doesn't match overridden member (possibly because of nullability attributes).
Member
|
Indeed -- dotnet/msbuild#13197 should fix. Thanks for the ping! |
Member
|
Thanks. Btw you could have fixed this directly here in this PR and the change would have then flown back to msbuild. Just a note for the future in case you want to go that route. |
rainersigwald
added a commit
to dotnet/msbuild
that referenced
this pull request
Feb 4, 2026
The doc comment explicitly mentions returning null and the SDK can do so, which caused a break in dotnet/dotnet#4579: src\sdk\src\Resolvers\Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver\WorkloadSdkResolver.cs(35,36): error CS8764: Nullability of return type doesn't match overridden member (possibly because of nullability attributes). Follow up to #13157 / 0172c58.
Contributor
Author
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
Contributor
Author
|
Note PRs from original repository included in this codeflow update:
💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance. |
ViktorHofer
approved these changes
Feb 6, 2026
ViktorHofer
deleted the
darc-main-e5875312-5e2d-44d5-8949-2aefb30abf25
branch
JanProvaznik
pushed a commit
to JanProvaznik/msbuild
that referenced
this pull request
Feb 25, 2026
The doc comment explicitly mentions returning null and the SDK can do so, which caused a break in dotnet/dotnet#4579: src\sdk\src\Resolvers\Microsoft.NET.Sdk.WorkloadMSBuildSdkResolver\WorkloadSdkResolver.cs(35,36): error CS8764: Nullability of return type doesn't match overridden member (possibly because of nullability attributes). Follow up to dotnet#13157 / 0172c58.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a codeflow update. It may contain both source code changes from
the source repo
as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/msbuild
Diff the source with this PR branch