Skip to content

Update license scan image to use .NET 11#4178

Merged
NikolaMilosavljevic merged 1 commit intodotnet:mainfrom
NikolaMilosavljevic:ls.11
Jan 15, 2026
Merged

Update license scan image to use .NET 11#4178
NikolaMilosavljevic merged 1 commit intodotnet:mainfrom
NikolaMilosavljevic:ls.11

Conversation

@NikolaMilosavljevic
Copy link
Member

Fixes: #4177

@NikolaMilosavljevic NikolaMilosavljevic requested review from a team as code owners January 13, 2026 21:41
Copilot AI review requested due to automatic review settings January 13, 2026 21:41
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Docker container images used for VMR license scan tests from .NET 10.0 to .NET 11.0 to resolve test failures caused by the missing .NET 11 SDK.

Changes:

  • Updated container image tags from net10.0 to net11.0 in both official and unofficial license scan pipeline configurations

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
eng/pipelines/vmr-license-scan.yml Updated the azurelinuxSourceBuildTestContainer image to use .NET 11.0 instead of .NET 10.0
eng/pipelines/vmr-license-scan-unofficial.yml Updated the azurelinuxSourceBuildTestContainer image to use .NET 11.0 instead of .NET 10.0

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mthalman
Copy link
Member

@ViktorHofer
Copy link
Member

ViktorHofer commented Jan 14, 2026

I don't know much about this code path but would it make sense to use eng/common/dotnet.sh here

to avoid the dependency on an installed SDK?

dotnet.sh automatically restores the SDK if it isn't installed on the machine, based on the global.json setting.

@mthalman
Copy link
Member

Yeah, that's a good point. Something to look at.

@NikolaMilosavljevic
Copy link
Member Author

Dependent PR was green and merged this morning - dotnet/dotnet-buildtools-prereqs-docker#1575

I am merging this one now.

@NikolaMilosavljevic NikolaMilosavljevic merged commit d03235c into dotnet:main Jan 15, 2026
17 checks passed
@ViktorHofer
Copy link
Member

Please make sure to track my feedback somewhere. I think it makes sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

License Scan tests failing in main

4 participants