Skip to content

Skip building of workload manifests#4166

Merged
mthalman merged 1 commit intodotnet:release/10.0.2xxfrom
mthalman:dev/mthalman/4155-duplicate-workloads
Jan 13, 2026
Merged

Skip building of workload manifests#4166
mthalman merged 1 commit intodotnet:release/10.0.2xxfrom
mthalman:dev/mthalman/4155-duplicate-workloads

Conversation

@mthalman
Copy link
Member

Fixes #4155

The 10.0.2xx build fails during darc publishing because there are multiple workload manifest packages described in MergedManifest.xml with duplicate names. For example:

<Package Id="Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100-preview.0" Version="10.0.100" DotNetReleaseShipping="true" PipelineArtifactName="Windows_x64_Artifacts" PipelineArtifactPath="packages/Release/Shipping/sdk/Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100-preview.0.10.0.100.nupkg" RepoOrigin="sdk" Visibility="External" />
<Package Id="Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100-preview.0" Version="10.0.200-preview.0.26062.102" DotNetReleaseShipping="true" PipelineArtifactName="Windows_x64_Artifacts" PipelineArtifactPath="packages/Release/Shipping/sdk/Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100-preview.0.10.0.200-preview.0.26062.102.nupkg" RepoOrigin="sdk" Visibility="External" />

In fact, neither of these packages should be output by the build. For 2xx, the intent is to use the downloaded 10.0.100 manifest packages, not build new ones.

@mthalman mthalman requested review from a team as code owners January 13, 2026 14:03
@dotnet-policy-service dotnet-policy-service bot requested a review from a team January 13, 2026 14:04
@mthalman mthalman merged commit b7db400 into dotnet:release/10.0.2xx Jan 13, 2026
7 checks passed
@mthalman mthalman deleted the dev/mthalman/4155-duplicate-workloads branch January 13, 2026 18:22
@dotnet-policy-service dotnet-policy-service bot requested a review from a team January 13, 2026 18:22
@mthalman
Copy link
Member Author

/backport to main

@github-actions
Copy link
Contributor

Started backporting to main (link to workflow run)

@github-actions
Copy link
Contributor

@mthalman backporting to main failed, the patch most likely resulted in conflicts. Please backport manually!

git am output
$ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch

Applying: Skip building of workload manifests
Using index info to reconstruct a base tree...
M	repo-projects/sdk.proj
M	src/sdk/src/Workloads/Manifests/manifest-packages.csproj
Falling back to patching base and 3-way merge...
Auto-merging repo-projects/sdk.proj
CONFLICT (content): Merge conflict in repo-projects/sdk.proj
Auto-merging src/sdk/src/Workloads/Manifests/manifest-packages.csproj
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Skip building of workload manifests
Error: The process '/usr/bin/git' failed with exit code 128

Link to workflow output

mthalman added a commit to mthalman/dotnet that referenced this pull request Jan 13, 2026
This was referenced Jan 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants