Use DayOfYear for file version to preserve date info and avoid overflow#4044
Closed
Use DayOfYear for file version to preserve date info and avoid overflow#4044
Conversation
Merged
Changed ToString("dd") to DayOfYear in both FileVersion lines.
This preserves date information (day 1-366) while staying under
the 16-bit limit (max 7366 for year 2026 vs 65535 limit).
Co-authored-by: ViktorHofer <[email protected]>
Copilot
AI
changed the title
[WIP] Address feedback for build fix from PR #4043
Use DayOfYear for file version to preserve date info and avoid overflow
Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The original patch fixed a 16-bit overflow (70105 > 65535) by changing
ToString("MMdd")toToString("dd"), but this removed month information from the FileVersion.Changes
ToString("dd")withDayOfYearproperty in the patchThis preserves temporal information as day-of-year (1-366) while keeping values under the limit (max: 7366).
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.