Fix build by ViktorHofer · Pull Request #4043 · dotnet/dotnet

ViktorHofer · 2026-01-05T10:11:52Z

Copilot

Pull request overview

This PR addresses build issues by applying a patch to fix assembly version calculation in 2026 and adding a workaround for a known dotnet issue.

Adds a patch to modify the FileVersion calculation for the azure-activedirectory-identitymodel-extensions-for-dotnet package
Excludes Microsoft.VisualStudio.TestPlatform.Common.dll from ReadyToRun publishing to work around #3995

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
src/source-build-reference-packages/src/externalPackages/patches/azure-activedirectory-identitymodel-extensions-for-dotnet/0002-Fix-assembly-version-calculation-in-2026.patch	Adds a patch that modifies the FileVersion date format calculation to address year 2026 issues
src/roslyn/src/LanguageServer/Microsoft.CodeAnalysis.LanguageServer/Microsoft.CodeAnalysis.LanguageServer.csproj	Adds PublishReadyToRunExclude for a specific DLL as a workaround for a known dotnet issue

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

...tory-identitymodel-extensions-for-dotnet/0002-Fix-assembly-version-calculation-in-2026.patch

Copilot · 2026-01-05T10:16:03Z

@ViktorHofer I've opened a new pull request, #4044, to work on those changes. Once the pull request is ready, I'll request review from you.

T-Gro · 2026-01-05T14:34:14Z

Will this workaround get backported to 10.0.200 ?
I think it exhibits the same issue.

mthalman · 2026-01-05T14:43:28Z

@ViktorHofer - Please create an issue for this in the identitymodel repo and link to it from the patch.

ViktorHofer · 2026-01-05T15:05:22Z

AzureAD/azure-activedirectory-identitymodel-extensions-for-dotnet#3388 is the issue in the repo.

Partial backport of dotnet/dotnet#4043

ViktorHofer · 2026-01-05T15:16:31Z

Backports:

[release/10.0] Add patch to fix building identitymodel submodule source-build-reference-packages#1522
[release/9.0] Add patch to fix building identitymodel submodule source-build-externals#513

Couldn't find the same affected line of code in 8.0.

* Add patch to fix building identitymodel submodule Partial backport of dotnet/dotnet#4043 * Fix FileVersion calculation in 2026 patch Fixes the FileVersion calculation issue as reported in GitHub issue #3388.

* Add patch to fix building identitymodel submodule Partial backport of dotnet/dotnet#4043 * Delete patches/azure-activedirectory-identitymodel-extensions-for-dotnet/src/externalPackages/patches/azure-activedirectory-identitymodel-extensions-for-dotnet/0002-Fix-assembly-version-calculation-in-2026.patch * Create 0002-Fix-assembly-version-calculation-in-2026.patch

Co-authored-by: Eric St. John <[email protected]>

tmds · 2026-01-06T13:43:36Z

Couldn't find the same affected line of code in 8.0.

@ViktorHofer it's there, but implemented in a script:

https://github.com/dotnet/dotnet/blob/release/8.0.1xx/src/source-build-externals/src/azure-activedirectory-identitymodel-extensions-for-dotnet/updateAssemblyInfo.sh#L10C1-L16

MichaelSimons · 2026-01-06T15:23:25Z

Couldn't find the same affected line of code in 8.0.

@ViktorHofer it's there, but implemented in a script:

https://github.com/dotnet/dotnet/blob/release/8.0.1xx/src/source-build-externals/src/azure-activedirectory-identitymodel-extensions-for-dotnet/updateAssemblyInfo.sh#L10C1-L16

This was fixed in dotnet/source-build-externals@3cd5b46

tmds · 2026-01-06T15:56:56Z

Great, thanks for the quick fixes @ViktorHofer and @MichaelSimons!

Starting in 2026, the FileVersion calculation formula (Year-2019)*10000+MMdd in azure-activedirectory-identitymodel-extensions-for-dotnet exceeds UInt16 max (65535), causing CS7035 build errors. - dotnet 8: patch updateAssemblyInfo.sh (from v8.0.122 tarball) - dotnet 9: patch build/common.props (from v9.0.112 tarball) - dotnet 10: use externalPackages/patches/ mechanism New formula: 61232 + (year_offset * 416) + (month * 32) + day (valid until 2029, long-term fix needed upstream) Upstream: dotnet/dotnet#4043

Starting in 2026, the FileVersion calculation formula (Year-2019)*10000+MMdd in azure-activedirectory-identitymodel-extensions-for-dotnet exceeds UInt16 max (65535), causing CS7035 build errors. - dotnet 8: add patch to patches/ directory as 0003 (after 0002) - dotnet 9: patch build/common.props directly - dotnet 10: use externalPackages/patches/ mechanism New formula: 61232 + (year_offset * 416) + (month * 32) + day (valid until 2029, long-term fix needed upstream) Upstream: dotnet/dotnet#4043

1. Removed sdk ,runtime,aspnetcore,templating,roslyn,installer submodules. Source files of each product repository which are mirrored inside of their respective directories under dotnet/src. 2. Backporting PR:dotnet/dotnet#4043 to resolve source build failing in 2026 due to minor version being number greater than 65535. Issue link: dotnet/dotnet#4037 3. Changed dotnet-build to incorporate the vmr way of building .NET sdk https://github.com/dotnet/dotnet 4. Note: VMR way of cross building is only supported on .NET 10 and above. Revert back to the older installer way of building if any previous versions are needed.  Signed-off-by: Shreya Rao <[email protected]>

1. Removed sdk ,runtime,aspnetcore,templating,roslyn,installer submodules. Source files of each product repository which are mirrored inside of their respective directories under dotnet/src. 2. Backporting PR:dotnet/dotnet#4043 to resolve source build failing in 2026 due to minor version being number greater than 65535. Issue link: dotnet/dotnet#4037 3. Changed dotnet-build to incorporate the vmr way of building .NET sdk https://github.com/dotnet/dotnet 4. Note: VMR way of cross building is only supported on .NET 10 and above. Revert back to the older installer way of building if any previous versions are needed.  Signed-off-by: Shreya Rao <[email protected]> Fixed branding paramater Signed-off-by: Shreya Rao <[email protected]>

1. Removed sdk ,runtime,aspnetcore,templating,roslyn,installer submodules. Source files of each product repository which are mirrored inside of their respective directories under dotnet/src. 2. Backporting PR:dotnet/dotnet#4043 to resolve source build failing in 2026 due to minor version being number greater than 65535. Issue link: dotnet/dotnet#4037 3. Changed dotnet-build to incorporate the vmr way of building .NET sdk https://github.com/dotnet/dotnet 4. Note: VMR way of cross building is only supported on .NET 10 and above. Revert back to the older installer way of building if any previous versions are needed.  Signed-off-by: Shreya Rao <[email protected]> Fixed branding paramater Signed-off-by: Shreya Rao <[email protected]> Fix lint errors Signed-off-by: Shreya Rao <[email protected]>

1. Removed sdk ,runtime,aspnetcore,templating,roslyn,installer submodules. Source files of each product repository which are mirrored inside of their respective directories under dotnet/src. 2. Backporting PR:dotnet/dotnet#4043 to resolve source build failing in 2026 due to minor version being number greater than 65535. Issue link: dotnet/dotnet#4037 3. Changed dotnet-build to incorporate the vmr way of building .NET sdk https://github.com/dotnet/dotnet 4. Note: VMR way of cross building is only supported on .NET 10 and above. Revert back to the older installer way of building if any previous versions are needed.  5. Fixed branding paramater 6. Enabling building of older dotnet versions by manually applying the patch in source-build-externals. Signed-off-by: Shreya Rao <[email protected]>

Removed sdk ,runtime,aspnetcore,templating,roslyn,installer submodules. Source files of each product repository which are mirrored inside of their respective directories under dotnet/src. Backporting PR:Fix build dotnet/dotnet#4043 to resolve source build failing in 2026 due to minor version being number greater than 65535. Issue link: [Operational Issue]: Source build fails in 2026 dotnet/dotnet#4037 Changed dotnet-build to incorporate the vmr way of building .NET sdk https://github.com/dotnet/dotnet Note: VMR way of cross building is only supported on .NET 10 and above. Revert back to the older installer way of building if any previous versions are needed.  Bumped to .NET 11 Signed-off-by: Shreya Rao <[email protected]>

ViktorHofer and others added 2 commits January 5, 2026 11:11

Add patch for failing identitymodel submodule

c6af058

Disable crossgen of Microsoft.VisualStudio.TestPlatform.Common.dll

ba66985

Copilot AI review requested due to automatic review settings January 5, 2026 10:11

dotnet-policy-service bot requested a review from a team January 5, 2026 10:12

Copilot started reviewing on behalf of ViktorHofer January 5, 2026 10:13 View session

Copilot AI reviewed Jan 5, 2026

View reviewed changes

...tory-identitymodel-extensions-for-dotnet/0002-Fix-assembly-version-calculation-in-2026.patch Show resolved Hide resolved

Copilot AI mentioned this pull request Jan 5, 2026

Use DayOfYear for file version to preserve date info and avoid overflow #4044

Closed

ViktorHofer added 2 commits January 5, 2026 11:44

Fix FileVersion calculation in common.props

ecebdf4

fix comment

aaba42c

ViktorHofer mentioned this pull request Jan 5, 2026

[Operational Issue]: Source build fails in 2026 #4037

Closed

4 tasks

akoeplinger approved these changes Jan 5, 2026

View reviewed changes

ViktorHofer merged commit e64f84d into main Jan 5, 2026
11 checks passed

ViktorHofer deleted the FixBuild branch January 5, 2026 13:06

ViktorHofer added a commit to dotnet/source-build-reference-packages that referenced this pull request Jan 5, 2026

Add patch to fix building identitymodel submodule

16c9990

Partial backport of dotnet/dotnet#4043

ViktorHofer mentioned this pull request Jan 5, 2026

[release/10.0] Add patch to fix building identitymodel submodule dotnet/source-build-reference-packages#1522

Merged

ViktorHofer added a commit to dotnet/source-build-externals that referenced this pull request Jan 5, 2026

Add patch to fix building identitymodel submodule

f2026b1

Partial backport of dotnet/dotnet#4043

ViktorHofer mentioned this pull request Jan 5, 2026

[release/9.0] Add patch to fix building identitymodel submodule dotnet/source-build-externals#513

Merged

stdmnpkg pushed a commit to AOSC-Tracking/dotnet that referenced this pull request Jan 5, 2026

Fix build (dotnet#4043)

d1f3374

Co-authored-by: Eric St. John <[email protected]>

mmitche mentioned this pull request Jan 6, 2026

Diagnose crossgen failures in Microsoft.CodeAnalysis.LanguageServer + Re-enable dotnet/runtime#122931

Closed

mulatta mentioned this pull request Jan 12, 2026

Build failure: dotnetCorePackages.dotnet_10.vmr NixOS/nixpkgs#479348

Closed

3 tasks

mulatta mentioned this pull request Jan 13, 2026

dotnet: fix Y2026 FileVersion overflow (backport dotnet/dotnet#4043) NixOS/nixpkgs#479689

Closed

8 tasks

ShreyaLaxminarayan mentioned this pull request Jan 16, 2026

Migration to VMR way of cross-building .NET sdk IBM/dotnet-s390x#65

Closed

n0099 mentioned this pull request Jan 19, 2026

Build failure: dotnetCorePackages.sdk_9_0-source since Y2026 #479348 NixOS/nixpkgs#481603

Closed

3 tasks

ShreyaLaxminarayan mentioned this pull request Jan 19, 2026

[Operational Issue]: Source build failure in .NET 10 versions less than preview-7 #4268

Closed

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix build#4043

Fix build#4043
ViktorHofer merged 4 commits intomainfrom
FixBuild

ViktorHofer commented Jan 5, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI commented Jan 5, 2026

Uh oh!

Uh oh!

T-Gro commented Jan 5, 2026

Uh oh!

mthalman commented Jan 5, 2026

Uh oh!

ViktorHofer commented Jan 5, 2026

Uh oh!

ViktorHofer commented Jan 5, 2026

Uh oh!

tmds commented Jan 6, 2026

Uh oh!

MichaelSimons commented Jan 6, 2026

Uh oh!

tmds commented Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

Conversation

ViktorHofer commented Jan 5, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Copilot AI commented Jan 5, 2026

Uh oh!

Uh oh!

T-Gro commented Jan 5, 2026

Uh oh!

mthalman commented Jan 5, 2026

Uh oh!

ViktorHofer commented Jan 5, 2026

Uh oh!

ViktorHofer commented Jan 5, 2026

Uh oh!

tmds commented Jan 6, 2026

Uh oh!

MichaelSimons commented Jan 6, 2026

Uh oh!

tmds commented Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

ViktorHofer commented Jan 5, 2026 •

edited

Loading