Skip to content

Install .NET 8.0 when using darc#3857

Merged
premun merged 1 commit intodotnet:mainfrom
premun:prvysoky/darc-main
Dec 15, 2025
Merged

Install .NET 8.0 when using darc#3857
premun merged 1 commit intodotnet:mainfrom
premun:prvysoky/darc-main

Conversation

@premun
Copy link
Member

@premun premun commented Dec 12, 2025

Copies of latest eng/common files from Arcade to allow us to unpin darc.

@premun premun requested a review from a team as a code owner December 12, 2025 15:55
Copilot AI review requested due to automatic review settings December 12, 2025 15:55
@premun premun requested a review from a team as a code owner December 12, 2025 15:55
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the build infrastructure to ensure .NET 8.0 is installed when using the Darc (Maestro) tooling for publishing build assets. The changes include adding runtime source feed configuration and updating build agent images to newer versions.

  • Adds explicit .NET 8.0 installation before Darc operations to ensure compatibility
  • Configures internal runtime source feeds with authentication for Darc and SDK tasks
  • Updates validation job images from VS2022 to VS2026 preview
  • Reformats YAML indentation for consistency (parameters and steps sections)

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
eng/common/core-templates/post-build/post-build.yml Reformats parameters indentation, updates validation job images to VS2026 preview, adds .NET 8.0 installation and internal runtime configuration for Darc publishing stage
eng/common/core-templates/job/publish-build-assets.yml Adds internal source/runtime configuration templates, installs .NET 8.0 before Darc operations, configures runtime source feeds for SDK tasks

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@ViktorHofer ViktorHofer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@premun these changes will get overwritten with the next VMR re-bootstrap and won't flow anywhere. If you want to make the eng/common changes so that they flow to all repos, either make them in arcade or in src/arcade here.

@premun
Copy link
Member Author

premun commented Dec 15, 2025

@ViktorHofer I wanted to temporarily override this to fix publishing. I would not care about the overwrites.

But we rolled back Maestro instead in the end.

@premun
Copy link
Member Author

premun commented Dec 15, 2025

Okay, we will have another go at unpinning so this needs to be in (before we rebootstrap which will bring in these files anyway).

@premun premun merged commit 5d44331 into dotnet:main Dec 15, 2025
15 of 17 checks passed
@premun premun deleted the prvysoky/darc-main branch December 15, 2025 13:38
ellahathaway added a commit to ellahathaway/dotnet that referenced this pull request Dec 15, 2025
premun added a commit to premun/dotnet that referenced this pull request Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants