Skip to content

Add microsoft-2025 key for non-SHA1 repos #3734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mmitche merged 2 commits into from
Dec 9, 2025
Merged

Add microsoft-2025 key for non-SHA1 repos #3734

mmitche merged 2 commits into from
Dec 9, 2025

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Dec 8, 2025

No description provided.

Copilot AI review requested due to automatic review settings December 8, 2025 18:36
@dotnet-policy-service dotnet-policy-service bot requested a review from a team December 8, 2025 18:36
@mmitche
Copy link
Member Author

mmitche commented Dec 8, 2025

Should resolve #3682

@mmitche
Copy link
Member Author

mmitche commented Dec 8, 2025

/backport to release/10.0

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Started backporting to release/10.0 (link to workflow run)

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

@mmitche an error occurred while backporting to release/10.0. See the workflow output for details.

Copilot AI reviewed Dec 8, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a new Microsoft GPG public key (microsoft-2025.asc) to the key download list for signature verification of Linux packages. The addition targets distributions that do not support SHA1 signatures, complementing the existing key infrastructure.

Key changes:

  • Added microsoft-2025.asc key URL to the keyUrls array in DownloadAndConfigurePublicKeys method

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mmitche
Copy link
Member Author

mmitche commented Dec 8, 2025

/backport to release/10.0.1xx

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Started backporting to release/10.0.1xx (link to workflow run)

@mmitche
Copy link
Member Author

mmitche commented Dec 8, 2025

/backport to release/10.0.2xx

@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2025

Started backporting to release/10.0.2xx (link to workflow run)

This was referenced Dec 8, 2025
Merged
Merged
@mmitche mmitche enabled auto-merge (squash) December 8, 2025 19:24
@ellahathaway
Copy link
Member

ellahathaway commented Dec 8, 2025

Does this need to go into SignTool as well?

@dotnet-policy-service dotnet-policy-service bot requested a review from a team December 8, 2025 21:27
@mmitche
Copy link
Member Author

mmitche commented Dec 8, 2025

Does this need to go into SignTool as well?

Yes thanks

@mmitche mmitche merged commit caca985 into dotnet:main Dec 9, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@ellahathaway ellahathaway ellahathaway approved these changes

Assignees

No one assigned

Labels

None yet

Projects

.NET Unified Build
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mmitche @ellahathaway