Skip to content

[release/10.0.2xx] Source code updates from nuget/nuget.client#3687

Merged
dotnet-maestro[bot] merged 8 commits intorelease/10.0.2xxfrom
darc-release/10.0.2xx-2abcbc6c-c30b-4767-9c65-fec221f31034
Dec 13, 2025
Merged

[release/10.0.2xx] Source code updates from nuget/nuget.client#3687
dotnet-maestro[bot] merged 8 commits intorelease/10.0.2xxfrom
darc-release/10.0.2xx-2abcbc6c-c30b-4767-9c65-fec221f31034

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Dec 5, 2025

Note

This is a codeflow update. It may contain both source code changes from
the source repo
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/nuget/nuget.client

Diff the source with this PR branch
darc vmr diff --name-only https://github.com/nuget/nuget.client:f764caebef5937cff2802ba65208e8f43afc6a45..https://github.com/dotnet/dotnet:darc-release/10.0.2xx-2abcbc6c-c30b-4767-9c65-fec221f31034

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Dec 6, 2025

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@zivkan
Copy link
Member

zivkan commented Dec 6, 2025

@dotnet/prodconsvcs the WIndows build is failing with error:

D:\a_work\1\s\artifacts\source-built-sdks\Microsoft.DotNet.Arcade.Sdk\tools\Sign.proj(76,5): error SIGN004: Signing 3rd party library 'D:\a_work\1\s\src\sdk\artifacts\tmp\Release\ContainerSigning\4919\filjxfLkRBSgsCFFN3j3D6q_5m24kI/Spectre.Console.dll' with Microsoft certificate 'MicrosoftDotNet500'. The library is considered 3rd party library due to its copyright: 'Patrik Svensson, Phil Scott, Nils Andresen, Cédric Luthi, Frank Ray'.

But I think it was supposed to be fixed by

I tried merging the latest 10.0.2xx commits back into this PR, but it's still failing with the same error.

@premun
Copy link
Member

premun commented Dec 8, 2025

To me it looks like [this line] https://github.com/dotnet/sdk/blob/e300dea82e0248b0801f706914c96073c1bd5350/eng/Signing.props#L67)
is missing in the 2xx branch.

It seems like it is being added here: #3527

@dotnet-maestro
Copy link
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-maestro
Copy link
Contributor Author

@dotnet-maestro dotnet-maestro bot merged commit e127b60 into release/10.0.2xx Dec 13, 2025
13 checks passed
@dotnet-maestro dotnet-maestro bot deleted the darc-release/10.0.2xx-2abcbc6c-c30b-4767-9c65-fec221f31034 branch December 13, 2025 10:27
@dotnet-policy-service dotnet-policy-service bot requested a review from a team December 13, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants