[release/10.0.1xx] Allow default branding to be set by the VMR orchestrator#3668
Merged
ViktorHofer merged 1 commit intorelease/10.0.1xxfrom Dec 4, 2025
Merged
Conversation
Co-authored-by: Copilot <[email protected]> Co-authored-by: Matt Mitchell <[email protected]>
ViktorHofer
commented
Dec 3, 2025
ViktorHofer
changed the title
ViktorHofer
commented
Dec 3, 2025
MichaelSimons
approved these changes
Dec 4, 2025
Member
Author
|
This is definitely tell-mode, infrastructure only change. |
mmitche
added a commit
to mmitche/dotnet
that referenced
this pull request
Dec 5, 2025
When dotnet#3668 went it, it removed DotNetFinalVersionKind from being set at the root level of the VMR. This unintentionally was causing the VMR publishing process to mark all shipping assets as CouldBeStable=true when DotNetFinalVersionKind=release, rather than using the values that were coming from the repos. The fix here is to not set PublishingVersion at the repo level. This will cause VMR builds to use V4 publishing for the repo builds, which will set CouldBeStable appropriately. Only winforms and wpf were manually setting this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Manual backport of f59b33b