Fix SDK Diff Baseline Updater Tool case-sensitivity mismatch#3346
Merged
ellahathaway merged 6 commits intomainfrom Nov 26, 2025
Merged
Fix SDK Diff Baseline Updater Tool case-sensitivity mismatch#3346ellahathaway merged 6 commits intomainfrom
ellahathaway merged 6 commits intomainfrom
Conversation
… files - Changed API diff file naming from 'updatedApiDiff.suppression' to 'UpdatedApiDiff.suppression' - Updated PRCreator to use case-insensitive matching for files starting with 'Updated' - Modified ParseUpdatedFileName to handle case-insensitive extraction Co-authored-by: ellahathaway <[email protected]>
Copilot
AI
changed the title
[WIP] Fix SDK Diff Baseline Updater Tool for API diffs
Fix SDK Diff Baseline Updater Tool case-sensitivity mismatch
Nov 13, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a case-sensitivity mismatch in the SDK Diff Baseline Updater Tool that prevented PRs from being created for API diffs. Tests generated files with lowercase "updated" prefix, but the PR creation tool only matched files starting with capitalized "Updated".
Key Changes:
- Standardized test output to use capitalized filename prefix (
UpdatedApiDiff.suppression) - Implemented case-insensitive file matching in the PR creator tool
- Updated filename parsing logic to handle any capitalization of "updated" prefix
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/Microsoft.DotNet.SourceBuild.Tests/SdkContentTests.cs | Changed output filename from lowercase updatedApiDiff.suppression to capitalized UpdatedApiDiff.suppression to match expected naming convention |
| eng/tools/CreateBaselineUpdatePR/PRCreator.cs | Made file matching and parsing case-insensitive to handle both existing lowercase and new capitalized filenames |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: ellahathaway <[email protected]>
ellahathaway
approved these changes
Nov 24, 2025
mmitche
reviewed
Nov 24, 2025
Co-authored-by: mmitche <[email protected]>
mmitche
approved these changes
Nov 26, 2025
Member
|
/backport to release/10.0.1xx |
Member
|
/backport to release/10.0.2xx |
Contributor
|
Started backporting to |
Contributor
|
Started backporting to |
This was referenced Dec 2, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plan to fix SDK Diff Baseline Updater Tool:
Summary
Fixed the SDK Diff Baseline Updater Tool to properly handle API diff files by:
updatedApiDiff.suppressiontoUpdatedApiDiff.suppressionto match the expected naming conventionGetUpdatedFiles()to accept files starting with "updated" regardless of caseParseUpdatedFileName()to extract filenames using case-insensitive string operations and throw if file doesn't have the expected prefixUpdatedFilePrefixfor maintainabilityThe tool now works with both old (lowercase) and new (capitalized) file naming conventions, ensuring backward compatibility while standardizing on capital 'U' for new files.
Security Summary
No security vulnerabilities detected by CodeQL analysis.
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.