Exclude package assets in SB manifest#3117
Merged
mthalman merged 1 commit intoOct 27, 2025
Merged
Conversation
MichaelSimons
approved these changes
Oct 27, 2025
Member
Author
|
/backport to main |
Contributor
|
Started backporting to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3077
Darc publishing in the
release/10.0.2xxbranch is failing due to duplicate package entries in theMergedManifest.xmlfiles. This stems from the SB legs. Example snippet from the manifest that illustrates duplicate package IDs:This happens because of the special logic that gets triggered in non-1xx branches where shared component packages get added to the manifest explicitly. The problem is that this logic is also running in the 2nd publish pass which is specifically meant for the SB blob assets (SDK tarball, artifacts tarball) -- it is not meant to contain packages. It is this publish pass which produces the manifest that ends up going to darc for publishing.
The fix is to just ensure that we don't include the shared component packages as part of this 2nd publish pass. That allows the SB manifest to only contain the blob assets, not packages.