Skip to content

Don't publish Microsoft.NET.Workload.Mono.ToolChain.Current.Manifest from runtime build#3021

Merged
mmitche merged 1 commit intorelease/10.0.1xxfrom
akoeplinger-patch-1
Oct 29, 2025
Merged

Don't publish Microsoft.NET.Workload.Mono.ToolChain.Current.Manifest from runtime build#3021
mmitche merged 1 commit intorelease/10.0.1xxfrom
akoeplinger-patch-1

Conversation

@akoeplinger
Copy link
Member

@akoeplinger akoeplinger commented Oct 21, 2025

This regressed with dotnet/runtime@e5798b9 which removed removing the manifest packages from publishing in the runtime build with a runtime version number.

These packages are unused (only the ones with sdk-style version numbers are used) but they are confusing and they also seem to mess with darc dependency tracking.

Fixes #3019

…from runtime build

This regressed with dotnet/runtime@e5798b9 which removed removing the manifest packages from publishing in the runtime build.
@dotnet-policy-service dotnet-policy-service bot requested a review from a team October 21, 2025 15:02
@mmitche mmitche enabled auto-merge (squash) October 23, 2025 13:04
@mmitche mmitche disabled auto-merge October 23, 2025 13:04
@mmitche
Copy link
Member

mmitche commented Oct 23, 2025

@akoeplinger Any risk for 10.0 that means we should get this in today (or not?)

@akoeplinger
Copy link
Member Author

@mmitche in theory it has no risk as nothing should be using these packages.

but that also means it's "just" about reducing human confusion so I'd be fine taking this in 10.0.1 too

@akoeplinger
Copy link
Member Author

akoeplinger commented Oct 29, 2025

can you please approve so we can get this in for 10.0.1? thanks

Tell-mode, infrastructure change with no actual impact to the product, Servicing-approved.

@akoeplinger akoeplinger added the Servicing-approved Approved for servicing release label Oct 29, 2025
@mmitche mmitche merged commit de00d8e into release/10.0.1xx Oct 29, 2025
10 checks passed
@mmitche mmitche deleted the akoeplinger-patch-1 branch October 29, 2025 13:36
This was referenced Dec 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Servicing-approved Approved for servicing release

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants