Skip to content

Update API diff#2995

Merged
ellahathaway merged 1 commit into
dotnet:mainfrom
ellahathaway:fix-api-diff
Oct 20, 2025
Merged

Update API diff#2995
ellahathaway merged 1 commit into
dotnet:mainfrom
ellahathaway:fix-api-diff

Conversation

@ellahathaway

@ellahathaway ellahathaway commented Oct 20, 2025

Copy link
Copy Markdown
Member

@ellahathaway ellahathaway requested a review from a team as a code owner October 20, 2025 16:13
Copilot AI review requested due to automatic review settings October 20, 2025 16:13
@ellahathaway ellahathaway requested a review from a team as a code owner October 20, 2025 16:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes obsolete API difference suppressions from the SDK content tests, addressing issue #5378. The changes eliminate five suppression entries for various System attributes (ExperimentalAttribute, SetsRequiredMembersAttribute, CollectionBuilderAttribute, CompilerFeatureRequiredAttribute, and RequiredMemberAttribute) that were previously needed for the Microsoft.CodeAnalysis.Workspaces.MSBuild.BuildHost.dll in the dotnet-watch tool.

  • Removed five CP0001 diagnostic suppressions for System attribute types
  • All removed suppressions were related to the BuildHost-netcore component of dotnet-watch

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@ellahathaway ellahathaway enabled auto-merge (squash) October 20, 2025 16:16
@ellahathaway ellahathaway merged commit 7692f14 into dotnet:main Oct 20, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[internal/release/10.0.1xx & main] API Diff tests are failing

4 participants