Skip to content

Merge from rc2 release tag#2927

Merged
akoeplinger merged 71 commits intodotnet:release/10.0.1xxfrom
mmitche:merge-from-rc2-release-tag
Oct 17, 2025
Merged

Merge from rc2 release tag#2927
akoeplinger merged 71 commits intodotnet:release/10.0.1xxfrom
mmitche:merge-from-rc2-release-tag

Conversation

@mmitche
Copy link
Member

@mmitche mmitche commented Oct 15, 2025

No description provided.

dotnet-maestro bot and others added 30 commits September 23, 2025 02:00
…#2546)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…tnet#2545)

Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
…on every build

Recreate temp on linux using CreateTempSubdirectory on every build

Work item https://dev.azure.com/devdiv/DevDiv/_workitems/edit/2541147

----
#### AI description  (iteration 1)
#### PR Classification
This pull request is a platform-specific enhancement that refines temporary directory creation on Linux.

#### PR Summary
The changes update the temporary folder creation logic by replacing manual directory and permission management with .NET’s Directory.CreateTempSubdirectory on Linux.
- `src/msbuild/src/Shared/TempFileUtilities.cs`: Uses Directory.CreateTempSubdirectory for Linux builds instead of custom mkdir and chmod logic.
- `src/msbuild/src/Shared/TempFileUtilities.cs`: Simplifies non-Linux directory creation and removes the obsolete constant userRWX.
<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
…t#2565)

[release/10.0.1xx-rc2] Source code updates from dotnet/msbuild
…#2564)

[release/10.0.1xx-rc2] Source code updates from dotnet/roslyn
…2551)

[release/10.0.1xx-rc2] Source code updates from dotnet/razor
…t#2567)

[release/10.0.1xx-rc2] Source code updates from dotnet/msbuild
…t#2582)

[release/10.0.1xx-rc2] Source code updates from dotnet/msbuild
…otnet#2584)

[release/10.0.1xx-rc2] Source code updates from nuget/nuget.client
…o rc2 (dotnet#2589)

Co-authored-by: William Godbe <[email protected]>
Co-authored-by: Nikola Milosavljevic <[email protected]>
#### AI description  (iteration 1)
#### PR Classification
Bug fix to correct and enhance chunked HTTP request parsing.

#### PR Summary
This pull request refines the parsing logic for chunked requests by enforcing RFC9112 compliance, improving error detection for invalid chunk extensions, and adding comprehensive tests.
- `src/aspnetcore/src/Servers/Kestrel/test/InMemory.FunctionalTests/ChunkedRequestTests.cs`: Introduces new tests covering invalid newline sequences and chunk extension scenarios.
- `src/aspnetcore/src/Servers/Kestrel/Core/src/Internal/Http/Http1ChunkedEncodingMessageBody.cs`: Enhances the chunk extension parsing logic with stricter validations and conditional behavior based on an insecure parsing switch.
- `src/aspnetcore/src/Servers/Kestrel/Core/src/Internal/Http/RequestRejectionReason.cs`: Adds a new rejection reason (`BadChunkExtension`) to support improved error handling.
- `src/aspnetcore/src/Servers/Kestrel/Core/test/MessageBodyTests.cs`: Updates test inputs to align with the revised parsing behavior.
<!-- GitOpsUserAgent=GitOps.Apps.Server.pullrequestcopilot -->
…otnet#2587)

[release/10.0.1xx-rc2] Source code updates from nuget/nuget.client
…t#2591)

[release/10.0.1xx-rc2] Source code updates from dotnet/msbuild
…t#2597)

[release/10.0.1xx-rc2] Source code updates from dotnet/msbuild
Copy link
Member

@premun premun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mmitche a lot of changes is file permission change and it seems to be going from 0755 to 0644. Which changed here: 3b9f4df

Maybe you some file copying/merging went wrong on Windows?

@akoeplinger
Copy link
Member

@premun 644 is the more correct one, those xml files shouldn't be marked executable, but I agree we shouldn't change it as part of this PR probably to keep the diff easier.

@premun
Copy link
Member

premun commented Oct 16, 2025

I agree that +x on XMLs also caught my eye but to me, the more correct one is what is in the original repo's 10.0 branch so that we don't get conflicts each time they change in the future.

@dotnet-policy-service dotnet-policy-service bot requested a review from a team October 16, 2025 09:35
@akoeplinger
Copy link
Member

I reverted the file permission changes here and we can fix the permissions in the source repo separately

@akoeplinger
Copy link
Member

we can fix the permissions in the source repo separately

I looked a bit and this seems to be some side effect of how the packages are extracted in source-build-reference-packages (possibly even in the nuget apis). I don't think I care that much to open that can of worms :)

@akoeplinger
Copy link
Member

src/arcade/src/Microsoft.DotNet.SourceBuild/tasks/Microsoft.DotNet.SourceBuild.Tasks.csproj(0,0): error NU1903: (NETCORE_ENGINEERING_TELEMETRY=Restore) Package 'Microsoft.Build.Tasks.Core' 17.12.36 has a known high severity vulnerability, GHSA-w3q9-fxm7-j8fq

this just popped up, we need to fix it. not sure why it only shows on the iOSSimulator job though.

@akoeplinger akoeplinger merged commit 8598f14 into dotnet:release/10.0.1xx Oct 17, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

9 participants