[infra] Custom packages path for test scenario #2860
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikolaMilosavljevic
changed the title
NikolaMilosavljevic
changed the title
mthalman
approved these changes
Oct 13, 2025
NikolaMilosavljevic
merged commit 81a0819
into
dotnet:release/10.0.1xx
10 checks passed
Member
Author
|
/backport to main |
Contributor
Member
|
Thank you, @NikolaMilosavljevic! |
Member
|
/backport to release/10.0.2xx |
Contributor
|
Started backporting to release/10.0.2xx: https://github.com/dotnet/dotnet/actions/runs/18497193341 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: dotnet/source-build#5359
Fixing this by setting the
CustomPreviouslySourceBuiltPackagesPathproperty in both test and non-test scenarios.The failure was due to
dotnet/eng/init-source-only.proj
Lines 27 to 29 in 0a70a71
We were only setting
CustomPreviouslySourceBuiltPackagesPathfor non-test runs. For tests we were setting a different property:dotnet/build.sh
Lines 412 to 419 in 0a70a71
However,
CustomSourceBuiltPackagesPathisn't used anywhere.We do have a custom property with a similar name, that is used for tests to provide custom packages feed. I don't think we should set that property automatically - it doesn't seem that was the original intent -
dotnet/test/Microsoft.DotNet.SourceBuild.Tests/README.md
Lines 19 to 21 in 0a70a71