Use backward-compatible GUID generation in Wix 5 #2794
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces backward-compatible GUID generation in Wix 5 by adding the -bcgg flag across multiple build infrastructure components. The change ensures consistency in GUID generation between Wix versions to maintain compatibility.
Key Changes
- Added
AdditionalOptionsparameter toCreateWixBuildWixpacktask to support passing additional compiler flags - Configured build targets to automatically pass the
-bcggflag through compiler and linker options - Updated shared infrastructure to propagate additional options through the wix build and wixpack processes
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/arcade/src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateWixBuildWixpack.cs | Added AdditionalOptions property and logic to include additional command line arguments |
| src/arcade/src/Microsoft.DotNet.Build.Tasks.Installers/build/wix5/wix.targets | Added WixAdditionalOptions property with -bcgg flag and wired it through build process |
| src/sdk/src/Layout/pkg/windows/Directory.Build.targets | Added SetAdditionalWixOptions target and passed options to CreateWixBuildWixpack task |
| src/aspnetcore/src/Installers/Windows/Wix.targets | Added SetAdditionalWixOptions target and passed options to CreateWixBuildWixpack task |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/arcade/src/Microsoft.DotNet.Build.Tasks.Installers/src/CreateWixBuildWixpack.cs
Show resolved
Hide resolved
NikolaMilosavljevic
added
the
NO-MERGE
NikolaMilosavljevic
requested review from
PranavSenthilnathan,
joeloff and
wtgodbe
wtgodbe
approved these changes
Oct 8, 2025
PranavSenthilnathan
approved these changes
Oct 9, 2025
NikolaMilosavljevic
removed
the
NO-MERGE
joeloff
reviewed
Oct 9, 2025
joeloff
approved these changes
Oct 9, 2025
Member
Author
|
/backport to release/10.0.1xx |
Contributor
|
Started backporting to release/10.0.1xx: https://github.com/dotnet/dotnet/actions/runs/18535661258 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes the following changes:
CreateWixBuildWixpackto support additional build/compilation options-bcggto wix build and wixpack taskaspnetcoreandsdkinfra to add-bcggto Compiler options, and utilizeAdditionalOptionsin wixpack task to have the same option during wix repack-bcggoption