[release/10.0.1xx] Fix certificate selection for debs and fix signing validation for the new key (and all future new keys)#2723
Merged
Conversation
Member
Author
|
/backport to main |
Contributor
ellahathaway
approved these changes
Oct 3, 2025
mmitche
approved these changes
Oct 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
-newkey-deb files weren't being signed with the correct key.Also, we didn't import the new public key into our list of valid keys for signing validation. Add the new
microsoft-rolling.ascfile (which contains the new key and will contain all future new keys if the keys change again) so we can validate the new signatures forever (no matter when the keys change).