VMR vs MSFT signing comparison#264
Conversation
ViktorHofer
left a comment
ViktorHofer
left a comment
There was a problem hiding this comment.
@ellahathaway any reason why some YMLs are added to src/sdk? Also, GatherDrop.ps1 is already in the VMR under eng/
Ah I didn't realize that we had moved the vmr templates out of src/sdk/eng/pipelines. Same goes for GatherDrop.ps1, it used to be in src/sdk/eng. Will move them - thanks. |
ellahathaway
force-pushed
the
vmr-signing-comparison
branch
from
4dc8205 to
19eaecc
Compare
ellahathaway
force-pushed
the
vmr-signing-comparison
branch
from
19eaecc to
dc66a83
Compare
|
@dotnet/product-construction - gentle ping. Can I please get a review on this? Thanks! |
|
@ellahathaway The test pipeline didn't quite do a correct asset comparison. It fails to find the merged manifests and then doesn't compare any assets. |
The gather drop step fails with a 403 error when trying to download the merged manifest (known arcade issue that I’ve contacted FR about - they have a fix in flight), which is why the comparison failed. I will change the comparison to error when a manifest doesn’t exist. Edit: Addressed in 0e5559f |
Ahh that's right. That should be fixed now, in the latest rollout. |
3 participants
Closes dotnet/arcade#15192
This PR introduces new tooling for comparing the MSFT and VMR artifacts, naming the signing status of their signed files. Some notable changes in this PR include:
dotnet-unified-build-comparisonfor running the asset and signing comparison. This pipeline runs on every build of main and release branches and can also be run manually. On manual runs, signing asset comparison is run as specified. On automated runs, asset comparison is always run and signing comparision is run whensignEnabledis true.BuildComparerhas been reworked so that there are two sub-commands:assetsandsigning.Test pipeline run