Skip to content

Configure 10.0.2xx branch#2632

Merged
mthalman merged 13 commits into
dotnet:release/10.0.2xxfrom
mthalman:dev/mthalman/setup-2xx
Oct 6, 2025
Merged

Configure 10.0.2xx branch#2632
mthalman merged 13 commits into
dotnet:release/10.0.2xxfrom
mthalman:dev/mthalman/setup-2xx

Conversation

@mthalman

Copy link
Copy Markdown
Member
  • Deletes all the shared runtime-related repos as the source for these will be from the 10.0.1xx branch.
  • Updates branding
  • Adds the dependency on the 1xx sources from the latest RC2 build
  • Misc bug fixes in infrastructure

@mmitche

mmitche commented Sep 26, 2025

Copy link
Copy Markdown
Member

/azp run

@mmitche

mmitche commented Sep 26, 2025

Copy link
Copy Markdown
Member

/azp list

@mthalman mthalman marked this pull request as draft September 26, 2025 15:10
@mthalman

mthalman commented Sep 29, 2025

Copy link
Copy Markdown
Member Author

While it's not showing up in the PR build (because it's an online build), I do have a local build that is failing on these changes with this error:

/repos/dotnet/src/sdk/src/Layout/redist/redist.csproj error NU1102: Unable to find package microsoft.netcore.app.crossgen2.linux-x64 with version (= 10.0.0-rc.2.25475.109)
  - Found 1 version(s) in previously-source-built [ Nearest version: 10.0.0-rc.1.25451.107 ]
  - Versions from prebuilt were not considered
  - Versions from reference-packages were not considered
  - Versions from shared-components were not considered
  - Versions from source-built-fsharp were not considered
  - Versions from source-built-msbuild were not considered
  - Versions from source-built-nuget-client were not considered
  - Versions from source-built-razor were not considered
  - Versions from source-built-roslyn were not considered
  - Versions from source-built-source-build-reference-packages were not considered
  - Versions from source-built-templating were not considered
  - Versions from source-built-transport-arcade were not considered
  - Versions from source-built-transport-msbuild were not considered
  - Versions from source-built-transport-razor were not considered
  - Versions from source-built-vstest were not considered [/repos/dotnet/src/sdk/source-build.slnf]

This is because the portable package microsoft.netcore.app.crossgen2.linux-x64 is not being included in the SB artifacts which is the source of where this build would get that package. I don't even see it being included as a package output of the runtime repo from a 1xx VMR build. I only see the non-portable version of the package.

@jkoritzinsky - Is this related to #1912? Also, from the binlog, I see that the runtime's build is outputting this package to the Shipping directory, but then gets its MSBuild Artifact metadata changed to IsShipping=false, but still remaining at the Shipping directory (related to dotnet/runtime#116259). Is that a reason for it to not be included in the VMR output?

Related binlogs:

@mthalman

Copy link
Copy Markdown
Member Author

Another issue from the build:

GenerateAnalyzerConfigAndDocumentationFiles
    ReleaseTrackingOptOut = false
    ContainsPortedFxCopRules = true
    GenerateAnalyzerRulesMissingDocumentationFile = true
    AnalyzerDocumentationFileDir = /__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src
    AnalyzerSarifFileDir = /__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src
    AnalyzerConfigurationFileDir = /__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/docs
    PackagePropsFileName = Microsoft.CodeAnalysis.NetAnalyzers.props
    PackageTargetsFileName = Microsoft.CodeAnalysis.NetAnalyzers.targets
    DisableNETAnalyzersPackagePropsFileName = DisableNETAnalyzersForNuGetPackage.props
    AnalyzerDocumentationFileName = Microsoft.CodeAnalysis.NetAnalyzers.md
    AnalyzerSarifFileName = Microsoft.CodeAnalysis.NetAnalyzers.sarif
    AnalyzerConfigurationFileName = Analyzer Configuration.md
    ValidateOnlyFlag = false
    ValidateOnlyFlag = true
    _ValidateOffline = true
    _GenerateDocumentationAndConfigFilesPath = /__w/1/s/src/sdk/artifacts/bin/GenerateDocumentationAndConfigFiles/Release/net10.0/GenerateDocumentationAndConfigFiles.dll
    Exec
        Assembly = /__w/1/s/.dotnet/sdk/10.0.100-rc.1.25451.107/Microsoft.Build.Tasks.Core.dll
        Parameters
            Command = "/__w/1/s/.dotnet/dotnet" "/__w/1/s/src/sdk/artifacts/bin/GenerateDocumentationAndConfigFiles/Release/net10.0/GenerateDocumentationAndConfigFiles.dll" "-validateOnly:true" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Rulesets" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Editorconfig" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/GlobalAnalyzerConfigs" "/__w/1/s/src/sdk/artifacts/bin/" "Release" "netstandard2.0" "Microsoft.CodeAnalysis.NetAnalyzers.dll;Microsoft.CodeAnalysis.CSharp.NetAnalyzers.dll;Microsoft.CodeAnalysis.VisualBasic.NetAnalyzers.dll" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Build" "Microsoft.CodeAnalysis.NetAnalyzers.props" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Build" "Microsoft.CodeAnalysis.NetAnalyzers.targets" "DisableNETAnalyzersForNuGetPackage.props" "/__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src" "Microsoft.CodeAnalysis.NetAnalyzers.md" "/__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src" "Microsoft.CodeAnalysis.NetAnalyzers.sarif" "10.0.200" Microsoft.CodeAnalysis.NetAnalyzers true true false true
        CommandLineArguments = "/__w/1/s/.dotnet/dotnet" "/__w/1/s/src/sdk/artifacts/bin/GenerateDocumentationAndConfigFiles/Release/net10.0/GenerateDocumentationAndConfigFiles.dll" "-validateOnly:true" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Rulesets" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Editorconfig" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/GlobalAnalyzerConfigs" "/__w/1/s/src/sdk/artifacts/bin/" "Release" "netstandard2.0" "Microsoft.CodeAnalysis.NetAnalyzers.dll;Microsoft.CodeAnalysis.CSharp.NetAnalyzers.dll;Microsoft.CodeAnalysis.VisualBasic.NetAnalyzers.dll" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Build" "Microsoft.CodeAnalysis.NetAnalyzers.props" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Build" "Microsoft.CodeAnalysis.NetAnalyzers.targets" "DisableNETAnalyzersForNuGetPackage.props" "/__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src" "Microsoft.CodeAnalysis.NetAnalyzers.md" "/__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src" "Microsoft.CodeAnalysis.NetAnalyzers.sarif" "10.0.200" Microsoft.CodeAnalysis.NetAnalyzers true true false true
        One or more auto-generated documentation files were either edited manually, or not updated. Please revert changes made to the following files (if manually edited) and run `msbuild /t:pack` at the root of the repo to automatically update them:
            /__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers.sarif
        Errors
            /__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers.Package.csproj(92,5): error MSB3073: The command ""/__w/1/s/.dotnet/dotnet" "/__w/1/s/src/sdk/artifacts/bin/GenerateDocumentationAndConfigFiles/Release/net10.0/GenerateDocumentationAndConfigFiles.dll" "-validateOnly:true" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Rulesets" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Editorconfig" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/GlobalAnalyzerConfigs" "/__w/1/s/src/sdk/artifacts/bin/" "Release" "netstandard2.0" "Microsoft.CodeAnalysis.NetAnalyzers.dll;Microsoft.CodeAnalysis.CSharp.NetAnalyzers.dll;Microsoft.CodeAnalysis.VisualBasic.NetAnalyzers.dll" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Build" "Microsoft.CodeAnalysis.NetAnalyzers.props" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Build" "Microsoft.CodeAnalysis.NetAnalyzers.targets" "DisableNETAnalyzersForNuGetPackage.props" "/__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src" "Microsoft.CodeAnalysis.NetAnalyzers.md" "/__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src" "Microsoft.CodeAnalysis.NetAnalyzers.sarif" "10.0.200" Microsoft.CodeAnalysis.NetAnalyzers true true false true" exited with code 1. [/__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers.Package.csproj]

@mthalman

Copy link
Copy Markdown
Member Author

Another issue from the build that only happens in the vertical legs. For some reason, it's not consuming the correct version of System.CommandLine.

Errors
    D:\a\_work\1\s\src\sdk\src\Cli\dotnet\Parser.cs(430,30): error CS0506: 'Parser.PrintCliSchemaAction.Terminating': cannot override inherited member 'CommandLineAction.Terminating' because it is not marked virtual, abstract, or override [D:\a\_work\1\s\src\sdk\src\Cli\dotnet\dotnet.csproj]
    D:\a\_work\1\s\src\sdk\src\Cli\dotnet\Commands\Workload\WorkloadCommandParser.cs(177,30): error CS0506: 'WorkloadCommandParser.ShowWorkloadsInfoAction.Terminating': cannot override inherited member 'CommandLineAction.Terminating' because it is not marked virtual, abstract, or override [D:\a\_work\1\s\src\sdk\src\Cli\dotnet\dotnet.csproj]
    D:\a\_work\1\s\src\sdk\src\Cli\dotnet\Commands\Workload\WorkloadCommandParser.cs(189,30): error CS0506: 'WorkloadCommandParser.ShowWorkloadsVersionOption.Terminating': cannot override inherited member 'CommandLineAction.Terminating' because it is not marked virtual, abstract, or override [D:\a\_work\1\s\src\sdk\src\Cli\dotnet\dotnet.csproj]

@jkoritzinsky

Copy link
Copy Markdown
Member

While it's not showing up in the PR build (because it's an online build), I do have a local build that is failing on these changes with this error:

/repos/dotnet/src/sdk/src/Layout/redist/redist.csproj error NU1102: Unable to find package microsoft.netcore.app.crossgen2.linux-x64 with version (= 10.0.0-rc.2.25475.109)
  - Found 1 version(s) in previously-source-built [ Nearest version: 10.0.0-rc.1.25451.107 ]
  - Versions from prebuilt were not considered
  - Versions from reference-packages were not considered
  - Versions from shared-components were not considered
  - Versions from source-built-fsharp were not considered
  - Versions from source-built-msbuild were not considered
  - Versions from source-built-nuget-client were not considered
  - Versions from source-built-razor were not considered
  - Versions from source-built-roslyn were not considered
  - Versions from source-built-source-build-reference-packages were not considered
  - Versions from source-built-templating were not considered
  - Versions from source-built-transport-arcade were not considered
  - Versions from source-built-transport-msbuild were not considered
  - Versions from source-built-transport-razor were not considered
  - Versions from source-built-vstest were not considered [/repos/dotnet/src/sdk/source-build.slnf]

This is because the portable package microsoft.netcore.app.crossgen2.linux-x64 is not being included in the SB artifacts which is the source of where this build would get that package. I don't even see it being included as a package output of the runtime repo from a 1xx VMR build. I only see the non-portable version of the package.

@jkoritzinsky - Is this related to #1912? Also, from the binlog, I see that the runtime's build is outputting this package to the Shipping directory, but then gets its MSBuild Artifact metadata changed to IsShipping=false, but still remaining at the Shipping directory (related to dotnet/runtime#116259). Is that a reason for it to not be included in the VMR output?

Related binlogs:

It looks like the SDK that you're building the 10.0.2xx band with is a Microsoft SDK, not the source-built SDK from the 10.0.1xx build? With the changes we've made for the RID handling for source-build, the expectation here is that using a portable SDK here would require pulling down the portable Microsoft.NETCore.App.Crossgen2.linux-x64 package and building with the source-built 10.0.1xx SDK will use the source-built Microsoft.NETCore.App.Crossgen2.<source-build-rid> package.

@mthalman

mthalman commented Sep 29, 2025

Copy link
Copy Markdown
Member Author

It looks like the SDK that you're building the 10.0.2xx band with is a Microsoft SDK, not the source-built SDK from the 10.0.1xx build?

That's correct.

With the changes we've made for the RID handling for source-build, the expectation here is that using a portable SDK here would require pulling down the portable Microsoft.NETCore.App.Crossgen2.linux-x64 package and building with the source-built 10.0.1xx SDK will use the source-built Microsoft.NETCore.App.Crossgen2.<source-build-rid> package.

We essentially want to replicate the behavior that is occurring in the 1xx build. In 1xx, the build of the sdk repo gets to reference the portable crossgen package. To do that, we need a way to get the portable package which would be done via the artifacts.

I don't quite understand what issue was being fixed by removing the portable package from the artifacts. But can it be solved in an alternative way that would condition the referencing of the crossgen package on whether the SDK being used is portable or not?

@jkoritzinsky

Copy link
Copy Markdown
Member

The "portable" package that exists in the source-build vertical and isn't published isn't identical to the portable build. It's a mix between portable and source-built LKG assets.

Its existence is only to provide a package with the name that the LKG SDK can find when looking for the crossgen2/ilc tool packs.

Additionally, @tmds requested that we remove this package from the SG assets tarball as they don't want portable assets in the tarball (and they didn't exist pre-VMR due to how how the old half-working crossgen setup in aspnetcore and sdk worked).

We can't make the SDK guess the RID for source-build as it has no way to know if the machine is compatible with that RID (ie the cross-build source-build scenario, which our community uses for community-supported OS and architecture builds), so the tooling relies on the SDK's reported RID.

You could disable crossgen by updating the condition for IsCrossgenSupported at https://github.com/dotnet/sdk/blob/8b95e275b0d8d51c76892676576f80ac9e421181/src/Layout/redist/targets/Crossgen.targets#L5 to exclude source-build feature bands.

Alternatively, if the build can consume portable bits, why can't we have the build download the 1xx portable tarball in addition to the 1xx source-build tarball?

@jkoritzinsky

Copy link
Copy Markdown
Member

Another question: Do we want the feature bands building against the runtimes from the shared components tarball, or do we want them building against the bits in the LKG SDK?

If we were to want to build them against the LKG SDK, then we could consume the crossgen2 that matches the SDK (which I assume is accessible at this point based on the failure message).

I expect that this isn't what we want though, so that solution wouldn't work.

@tmds

tmds commented Sep 30, 2025

Copy link
Copy Markdown
Member

Additionally, @tmds requested that we remove this package from the SG assets tarball as they don't want portable assets in the tarball (and they didn't exist pre-VMR due to how how the old half-working crossgen setup in aspnetcore and sdk worked).

Rids should enable us to express compatibility without building "pretend" portable assets. Having non-portable SDK build produce portable assets has been a source of bugs, like dotnet/source-build#5225, so I prefer to avoid it.

@mthalman

Copy link
Copy Markdown
Member Author

Ok, confirmed that using the non-portable source-built SDK resolves the issue. This should be fine. It's not too disruptive to adjust to that.

@mthalman

Copy link
Copy Markdown
Member Author

Another issue from the build:

GenerateAnalyzerConfigAndDocumentationFiles
    ReleaseTrackingOptOut = false
    ContainsPortedFxCopRules = true
    GenerateAnalyzerRulesMissingDocumentationFile = true
    AnalyzerDocumentationFileDir = /__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src
    AnalyzerSarifFileDir = /__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src
    AnalyzerConfigurationFileDir = /__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/docs
    PackagePropsFileName = Microsoft.CodeAnalysis.NetAnalyzers.props
    PackageTargetsFileName = Microsoft.CodeAnalysis.NetAnalyzers.targets
    DisableNETAnalyzersPackagePropsFileName = DisableNETAnalyzersForNuGetPackage.props
    AnalyzerDocumentationFileName = Microsoft.CodeAnalysis.NetAnalyzers.md
    AnalyzerSarifFileName = Microsoft.CodeAnalysis.NetAnalyzers.sarif
    AnalyzerConfigurationFileName = Analyzer Configuration.md
    ValidateOnlyFlag = false
    ValidateOnlyFlag = true
    _ValidateOffline = true
    _GenerateDocumentationAndConfigFilesPath = /__w/1/s/src/sdk/artifacts/bin/GenerateDocumentationAndConfigFiles/Release/net10.0/GenerateDocumentationAndConfigFiles.dll
    Exec
        Assembly = /__w/1/s/.dotnet/sdk/10.0.100-rc.1.25451.107/Microsoft.Build.Tasks.Core.dll
        Parameters
            Command = "/__w/1/s/.dotnet/dotnet" "/__w/1/s/src/sdk/artifacts/bin/GenerateDocumentationAndConfigFiles/Release/net10.0/GenerateDocumentationAndConfigFiles.dll" "-validateOnly:true" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Rulesets" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Editorconfig" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/GlobalAnalyzerConfigs" "/__w/1/s/src/sdk/artifacts/bin/" "Release" "netstandard2.0" "Microsoft.CodeAnalysis.NetAnalyzers.dll;Microsoft.CodeAnalysis.CSharp.NetAnalyzers.dll;Microsoft.CodeAnalysis.VisualBasic.NetAnalyzers.dll" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Build" "Microsoft.CodeAnalysis.NetAnalyzers.props" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Build" "Microsoft.CodeAnalysis.NetAnalyzers.targets" "DisableNETAnalyzersForNuGetPackage.props" "/__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src" "Microsoft.CodeAnalysis.NetAnalyzers.md" "/__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src" "Microsoft.CodeAnalysis.NetAnalyzers.sarif" "10.0.200" Microsoft.CodeAnalysis.NetAnalyzers true true false true
        CommandLineArguments = "/__w/1/s/.dotnet/dotnet" "/__w/1/s/src/sdk/artifacts/bin/GenerateDocumentationAndConfigFiles/Release/net10.0/GenerateDocumentationAndConfigFiles.dll" "-validateOnly:true" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Rulesets" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Editorconfig" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/GlobalAnalyzerConfigs" "/__w/1/s/src/sdk/artifacts/bin/" "Release" "netstandard2.0" "Microsoft.CodeAnalysis.NetAnalyzers.dll;Microsoft.CodeAnalysis.CSharp.NetAnalyzers.dll;Microsoft.CodeAnalysis.VisualBasic.NetAnalyzers.dll" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Build" "Microsoft.CodeAnalysis.NetAnalyzers.props" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Build" "Microsoft.CodeAnalysis.NetAnalyzers.targets" "DisableNETAnalyzersForNuGetPackage.props" "/__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src" "Microsoft.CodeAnalysis.NetAnalyzers.md" "/__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src" "Microsoft.CodeAnalysis.NetAnalyzers.sarif" "10.0.200" Microsoft.CodeAnalysis.NetAnalyzers true true false true
        One or more auto-generated documentation files were either edited manually, or not updated. Please revert changes made to the following files (if manually edited) and run `msbuild /t:pack` at the root of the repo to automatically update them:
            /__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers.sarif
        Errors
            /__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers.Package.csproj(92,5): error MSB3073: The command ""/__w/1/s/.dotnet/dotnet" "/__w/1/s/src/sdk/artifacts/bin/GenerateDocumentationAndConfigFiles/Release/net10.0/GenerateDocumentationAndConfigFiles.dll" "-validateOnly:true" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Rulesets" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Editorconfig" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/GlobalAnalyzerConfigs" "/__w/1/s/src/sdk/artifacts/bin/" "Release" "netstandard2.0" "Microsoft.CodeAnalysis.NetAnalyzers.dll;Microsoft.CodeAnalysis.CSharp.NetAnalyzers.dll;Microsoft.CodeAnalysis.VisualBasic.NetAnalyzers.dll" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Build" "Microsoft.CodeAnalysis.NetAnalyzers.props" "/__w/1/s/src/sdk/artifacts/bin/Microsoft.CodeAnalysis.NetAnalyzers.Package/Build" "Microsoft.CodeAnalysis.NetAnalyzers.targets" "DisableNETAnalyzersForNuGetPackage.props" "/__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src" "Microsoft.CodeAnalysis.NetAnalyzers.md" "/__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src" "Microsoft.CodeAnalysis.NetAnalyzers.sarif" "10.0.200" Microsoft.CodeAnalysis.NetAnalyzers true true false true" exited with code 1. [/__w/1/s/src/sdk/src/Microsoft.CodeAnalysis.NetAnalyzers/src/Microsoft.CodeAnalysis.NetAnalyzers.Package.csproj]

Should be resolved by aed52d3.

@mthalman mthalman marked this pull request as ready for review October 1, 2025 17:24

@MichaelSimons MichaelSimons left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to capture some information while it is fresh in your mind on what the process will look like when we branch for 11.0.2xx. It looks like it is mainly, remove "runtime" source, update branding, trigger the flow from 11.0.1xx?

@mthalman

mthalman commented Oct 2, 2025

Copy link
Copy Markdown
Member Author

It would be good to capture some information while it is fresh in your mind on what the process will look like when we branch for 11.0.2xx. It looks like it is mainly, remove "runtime" source, update branding, trigger the flow from 11.0.1xx?

#2707

@mthalman mthalman requested a review from mmitche October 2, 2025 19:49
@mthalman

mthalman commented Oct 6, 2025

Copy link
Copy Markdown
Member Author

@mmitche - PTAL

Comment thread eng/download-source-built-archive.sh
Comment thread eng/pipelines/official.yml Outdated
Comment thread eng/pipelines/pr.yml Outdated
@mthalman mthalman requested a review from mmitche October 6, 2025 17:46
@mthalman mthalman merged commit bddfa0d into dotnet:release/10.0.2xx Oct 6, 2025
1 of 2 checks passed
@mthalman mthalman deleted the dev/mthalman/setup-2xx branch October 6, 2025 18:46
@dotnet-policy-service dotnet-policy-service Bot requested a review from a team October 6, 2025 18:46
@mthalman

mthalman commented Oct 6, 2025

Copy link
Copy Markdown
Member Author

@premun / @dkurepa - I don't know what subscription configuration is needed to setup the 2xx branch. Can you help with that?

@premun

premun commented Oct 7, 2025

Copy link
Copy Markdown
Member

@mthalman what do you want to happen?

@mthalman

mthalman commented Oct 7, 2025

Copy link
Copy Markdown
Member Author

@premun We need subscriptions created as described in #1108

@premun

premun commented Oct 7, 2025

Copy link
Copy Markdown
Member

@mthalman but are there any nuances? Some packages that need to be pinned?

Or do we want to update every single src/Version.Details.xml with every package built in the 1xx UB?
Do we want to update the root V.D.xml somehow too?

@dkurepa

dkurepa commented Oct 7, 2025

Copy link
Copy Markdown
Member

@mthalman using the latest darc you should be able to do this using the darc add-subscription command, where you provide the specific VMR repo paths using the target-directory parameter.
Essentially, you'd create something like the test subscription I set up
image
but with a different target branch and any excluded assets you want.

Please let us know if you have any feedback on the subscription creation experience

@mthalman

mthalman commented Oct 7, 2025

Copy link
Copy Markdown
Member Author

@mthalman but are there any nuances? Some packages that need to be pinned?

Or do we want to update every single src/Version.Details.xml with every package built in the 1xx UB?

It should mirror the subscriptions that already exist for each repo. So, outside the context of the VMR, if the sdk repo has a dependency on a package from runtime, a similar subscription should exist for the VMR such that the sdk repo in dotnet (release/10.0.2xx) gets updates from the runtime repo in dotnet (release/10.0.1xx). Does that sound right, @mmitche?

Ideally, there'd be a system in place to keep these subscriptions in sync.

Do we want to update the root V.D.xml somehow too?

Yes. As stated in #1108:

The V.D.xml at the root of the VMR includes a non-stable version dependency on Microsoft.NET.Sdk

using the latest darc you should be able to do this using the darc add-subscription command, where you provide the specific VMR repo paths using the target-directory parameter.

How do you configure all these subscriptions to flow in one PR?

@premun

premun commented Oct 8, 2025

Copy link
Copy Markdown
Member

@mthalman if you configure these as per #1108 (comment)

You can target /,src/* which means root and all dirs under src/.

So it will be a single subscription which will update all V.D.xml in the VMR.
You can then exclude specific packages for specific folders as the original comment hints too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

7 participants