Fix x64 runtime installer on x86/arm64 #2615
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
NikolaMilosavljevic
approved these changes
Sep 25, 2025
PranavSenthilnathan
merged commit 195fc66
into
dotnet:release/10.0.1xx-rc2
10 checks passed
Member
Author
|
/backport to release/10.0.1xx |
Contributor
|
Started backporting to release/10.0.1xx: https://github.com/dotnet/dotnet/actions/runs/18024141634 |
Member
Author
|
/backport to main |
Contributor
This was referenced Sep 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/runtime#120108
When installing using an x64 installer on arm64, the PROGRAMFILES_DOTNET (used to place the host) is not correctly computed because WiX has not resolved
ProgramFiles6432Folderyet. This change makes it useProgramFiles64Folderinstead which is valid because this code only applies to x64 installers on x64/arm64 machines.Customer Impact
x64 installer fails when installing on arm64 and x86 (cleanup is handled gracefully, but the product is not installed).
Regression
Yes, introduced in WiX 5 when migrating from WiX 3 to use the new ProgramFile6432Folder property.
Testing
Manually verified the bug with the specified build, and then verified that the fix actually resolves the issue.
Risk
Low risk since the installer is already broken due to the bug.