Skip to content

Apply cDAC riscv64 patch #2512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
am11 wants to merge 3 commits into from
Closed

Apply cDAC riscv64 patch #2512

am11 wants to merge 3 commits into from

Conversation

@am11
Copy link
Member

@am11 am11 commented Sep 19, 2025

Testing CI for dotnet/runtime#117436.

@jkoritzinsky @akoeplinger could you please re-run the legs that were failing earlier (dotnet/runtime#117436 (comment))? That would help confirm whether the issue is resolved before the runtime PR gets merged.

@akoeplinger
Copy link
Member

akoeplinger commented Sep 19, 2025

/azp run dotnet-unified-build-full

@azure-pipelines
Copy link

azure-pipelines bot commented Sep 19, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@am11
Copy link
Member Author

am11 commented Sep 19, 2025 

##[error].dotnet/sdk/10.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(119,5): error MSB4018: (NETCORE_ENGINEERING_TELEMETRY=Build) The "ProcessFrameworkReferences" task failed unexpectedly.
System.ArgumentNullException: Value cannot be null. (Parameter 'key')
   at System.Collections.Generic.Dictionary`2.ContainsKey(TKey key)
   at Microsoft.NET.Build.Tasks.NuGetUtils.GetBestMatchingRidWithExclusion(RuntimeGraph runtimeGraph, String runtimeIdentifier, IEnumerable`1 runtimeIdentifiersToExclude, IEnumerable`1 availableRuntimeIdentifiers, Boolean& wasInGraph) in /_/src/sdk/src/Common/NuGetUtils.NuGet.cs:line 88
   at Microsoft.NET.Build.Tasks.ProcessFrameworkReferences.AddToolPack(ToolPackType toolPackType, Version normalizedTargetFrameworkVersion, List`1 packagesToDownload, List`1 implicitPackageReferences) in /_/src/sdk/src/Tasks/Microsoft.NET.Build.Tasks/ProcessFrameworkReferences.cs:line 812
   at Microsoft.NET.Build.Tasks.ProcessFrameworkReferences.ExecuteCore() in /_/src/sdk/src/Tasks/Microsoft.NET.Build.Tasks/ProcessFrameworkReferences.cs:line 441
   at Microsoft.NET.Build.Tasks.TaskBase.Execute() in /_/src/sdk/src/Tasks/Common/TaskBase.cs:line 36
   at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(TaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) in /_/src/msbuild/src/Build/BackEnd/Components/RequestBuilder/TaskBuilder.cs:line 816
  /__w/1/s/.dotnet/sdk/10.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(119,5): error MSB4018: The "ProcessFrameworkReferences" task failed unexpectedly. [/__w/1/s/src/runtime/src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Microsoft.Diagnostics.DataContractReader.Contracts.csproj]
  /__w/1/s/.dotnet/sdk/10.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(119,5): error MSB4018: System.ArgumentNullException: Value cannot be null. (Parameter 'key') [/__w/1/s/src/runtime/src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Microsoft.Diagnostics.DataContractReader.Contracts.csproj]
  /__w/1/s/.dotnet/sdk/10.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(119,5): error MSB4018:    at System.Collections.Generic.Dictionary`2.ContainsKey(TKey key) [/__w/1/s/src/runtime/src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Microsoft.Diagnostics.DataContractReader.Contracts.csproj]
  /__w/1/s/.dotnet/sdk/10.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(119,5): error MSB4018:    at Microsoft.NET.Build.Tasks.NuGetUtils.GetBestMatchingRidWithExclusion(RuntimeGraph runtimeGraph, String runtimeIdentifier, IEnumerable`1 runtimeIdentifiersToExclude, IEnumerable`1 availableRuntimeIdentifiers, Boolean& wasInGraph) in /_/src/sdk/src/Common/NuGetUtils.NuGet.cs:line 88 [/__w/1/s/src/runtime/src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Microsoft.Diagnostics.DataContractReader.Contracts.csproj]
  /__w/1/s/.dotnet/sdk/10.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(119,5): error MSB4018:    at Microsoft.NET.Build.Tasks.ProcessFrameworkReferences.AddToolPack(ToolPackType toolPackType, Version normalizedTargetFrameworkVersion, List`1 packagesToDownload, List`1 implicitPackageReferences) in /_/src/sdk/src/Tasks/Microsoft.NET.Build.Tasks/ProcessFrameworkReferences.cs:line 812 [/__w/1/s/src/runtime/src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Microsoft.Diagnostics.DataContractReader.Contracts.csproj]
  /__w/1/s/.dotnet/sdk/10.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(119,5): error MSB4018:    at Microsoft.NET.Build.Tasks.ProcessFrameworkReferences.ExecuteCore() in /_/src/sdk/src/Tasks/Microsoft.NET.Build.Tasks/ProcessFrameworkReferences.cs:line 441 [/__w/1/s/src/runtime/src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Microsoft.Diagnostics.DataContractReader.Contracts.csproj]
  /__w/1/s/.dotnet/sdk/10.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(119,5): error MSB4018:    at Microsoft.NET.Build.Tasks.TaskBase.Execute() in /_/src/sdk/src/Tasks/Common/TaskBase.cs:line 36 [/__w/1/s/src/runtime/src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Microsoft.Diagnostics.DataContractReader.Contracts.csproj]
  /__w/1/s/.dotnet/sdk/10.0.100-ci/Sdks/Microsoft.NET.Sdk/targets/Microsoft.NET.Sdk.FrameworkReferenceResolution.targets(119,5): error MSB4018:    at Microsoft.Build.BackEnd.TaskBuilder.ExecuteInstantiatedTask(TaskExecutionHost taskExecutionHost, TaskLoggingContext taskLoggingContext, TaskHost taskHost, ItemBucket bucket, TaskExecutionMode howToExecuteTask) in /_/src/msbuild/src/Build/BackEnd/Components/RequestBuilder/TaskBuilder.cs:line 816 [/__w/1/s/src/runtime/src/native/managed/cdac/Microsoft.Diagnostics.DataContractReader.Contracts/Microsoft.Diagnostics.DataContractReader.Contracts.csproj]

@jkoritzinsky, this one seems like related to RID graph.

@akoeplinger
Copy link
Member

akoeplinger commented Sep 19, 2025

I think this is just dotnet/sdk#50674 and the fix hasn't made it into VMR main yet

@akoeplinger
Copy link
Member

akoeplinger commented Sep 19, 2025 •
edited
Loading

The timeouts are #2513 and the WiX issues in Windows_x64_BuildPass2 are probably related to the recent WiX v5 bump (not sure why we don't see that one on the internal build I take that back we do see it)

@am11
Copy link
Member Author

am11 commented Sep 19, 2025

I think this is just dotnet/sdk#50674 and the fix hasn't made it into VMR main yet

Looks like https://github.com/dotnet/sdk/pull/50682/files was applied in d7e0124.

Since it is failing on Microsoft.Diagnostics.DataContractReader.Contracts.csproj, I think

dotnet/src/runtime/Build.proj

Line 33 in 5c817e9

<RidGraphFile Include="$(ArtifactsBinDir)Microsoft.NETCore.Platforms/*.json" />
is not taking effect? (note that in bootstrap build, we expect all projects to use the RID graph file from artifacts/bootstrap dir)

@jkoritzinsky
Copy link
Member

jkoritzinsky commented Sep 19, 2025

@am11 I think you might need to add GlobalPropertiesToRemove to the project references from the cdac itself to its corresponding ProjectReference items. That should remove the RIDs from those projects (which shouldn't be built with specific RIDs anyway)

@am11
Copy link
Member Author

am11 commented Sep 21, 2025

Looks like that too didn't work. :(

@am11
Copy link
Member Author

am11 commented Oct 1, 2025

@jkoritzinsky, when you get a chance, please take a look. Feel free to push to the branch. We can then apply the changes to dotnet/runtime#117436 and close this one; once the CI is green. 🙂

@dotnet-policy-service dotnet-policy-service bot requested a review from a team October 13, 2025 20:52
@am11
Copy link
Member Author

am11 commented Oct 14, 2025

Wow, merging main fixed it! Probably some other change in main might have helped. 😁

/azp run dotnet-unified-build-full

Can we try this one again? @steveisok, do you remember which official pipeline failed when part of cDAC configs were reverted in #1464 (and does dotnet-unified-build-full covers it)? We can run it against the PR for validation.

@steveisok
Copy link
Member

steveisok commented Oct 14, 2025

Can we try this one again? @steveisok, do you remember which official pipeline failed when part of cDAC configs were reverted in #1464 (and does dotnet-unified-build-full covers it)? We can run it against the PR for validation.

If I remember correctly, it's our internal dotnet-unified-build-full that failed. I can give that a run to see if it passes.

@akoeplinger
Copy link
Member

akoeplinger commented Oct 15, 2025

the public one should be equivalent I think, let's try

@akoeplinger
Copy link
Member

akoeplinger commented Oct 15, 2025

/azp run dotnet-unified-build-full

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 15, 2025

Azure Pipelines successfully started running 1 pipeline(s).

@steveisok
Copy link
Member

steveisok commented Oct 15, 2025

the public one should be equivalent I think, let's try

I kicked off an internal one yesterday and it looked good. Glad you commented because I would have forgot to follow up ;-)

@am11
Copy link
Member Author

am11 commented Oct 15, 2025

Thank you for testing! I have pushed the additional commit to upstream PR: dotnet/runtime#117436. We can close this and merge that one once CI/BA is green.

@am11
Copy link
Member Author

am11 commented Oct 15, 2025

All linux legs have passed. osx-arm64 leg is stuck around emsdk build. Closing. Thanks everyone for support! :)

@am11 am11 closed this Oct 15, 2025
@am11 am11 mentioned this pull request Oct 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

.NET Unified Build
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@am11 @akoeplinger @jkoritzinsky @steveisok