Skip to content

Add telemetry for the task host and task factory usage in MSBuild.#2488

Merged
baronfel merged 5 commits into
dotnet:release/10.0.1xxfrom
AR-May:dev/AR-May/add-msbuild-tasks-telemetry
Sep 22, 2025
Merged

Add telemetry for the task host and task factory usage in MSBuild.#2488
baronfel merged 5 commits into
dotnet:release/10.0.1xxfrom
AR-May:dev/AR-May/add-msbuild-tasks-telemetry

Conversation

@AR-May

@AR-May AR-May commented Sep 18, 2025

Copy link
Copy Markdown
Member

Fixes dotnet/msbuild#12507

Changes:
In MSBuild: Adding MSBuild project level telemetry collecting task host and task factories usage
In SDK: Adding new telemetry events processing to SDK

Telemetry events are sent per project build in MSBuild and then aggregated on SDK side.

Testing:
SDK part - unit tests
MSBuild part - manual testing, compared reported numbers to what is available in binlog, they seem to be correct

@surayya-MS surayya-MS left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@AR-May

AR-May commented Sep 18, 2025

Copy link
Copy Markdown
Member Author

After internal conversation decided that we will aggregate the new events on the SDK side and fire only one event per build.

@AR-May AR-May marked this pull request as ready for review September 19, 2025 14:35
@baronfel baronfel requested a review from dsplaisted September 19, 2025 14:49
@baronfel

Copy link
Copy Markdown
Member

cc @dsplaisted because of SDK telemetry

@baronfel baronfel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM from a functional perspective - but it should be targeted against release/10.0.1xx.

@AR-May AR-May changed the base branch from main to release/10.0.1xx September 19, 2025 15:59
@AR-May AR-May requested review from a team as code owners September 19, 2025 15:59
@AR-May AR-May force-pushed the dev/AR-May/add-msbuild-tasks-telemetry branch from 8b660e1 to fd8df96 Compare September 19, 2025 16:11
@AR-May AR-May removed request for a team September 19, 2025 16:12
@baronfel baronfel merged commit e7cc8b7 into dotnet:release/10.0.1xx Sep 22, 2025
10 checks passed
YuliiaKovalova pushed a commit to dotnet/msbuild that referenced this pull request Sep 29, 2025
### Changes Made

- Document new `ProjectTelemetry` telemetry from #12564 ([original PR in
VMR](dotnet/dotnet#2488))
- Add deprecated telemetry section to have a complete historical record
of the telemetry.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Add telemetry for single process multithreaded MSBuild

4 participants