Download shared components outside of prep script#2403
Merged
mthalman merged 2 commits intoSep 15, 2025
Conversation
MichaelSimons
approved these changes
Sep 15, 2025
Member
Author
|
/backport to main |
Contributor
Contributor
|
@mthalman backporting to "main" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Download shared components outside of prep script
Using index info to reconstruct a base tree...
M eng/pipelines/templates/jobs/vmr-build.yml
M eng/pipelines/templates/stages/source-build-and-validate.yml
Falling back to patching base and 3-way merge...
Auto-merging eng/pipelines/templates/jobs/vmr-build.yml
CONFLICT (content): Merge conflict in eng/pipelines/templates/jobs/vmr-build.yml
Auto-merging eng/pipelines/templates/stages/source-build-and-validate.yml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Download shared components outside of prep script
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/source-build#5332
Moves the logic for downloading the shared component artifacts out of the prep-source-build script so that it can be explicitly initiated by the VMR pipeline only. This avoids the scenario described by dotnet/source-build#5332.
To implement this, I refactored the prep script so that the archive downloading is in a separate standalone script. This allows the prep script and the pipeline logic to share a common implementation for this download logic.