[release/10.0.1xx] Add Winforms PackageOverrides to WindowsDesktop #2357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akoeplinger
approved these changes
Sep 11, 2025
Member
|
there's a merge conflict with the V.D.xml |
Member
Author
|
Yeah, that dang thing gets conflicts with every single commit. |
ericstj
added
Servicing-approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #2297
Customer Impact
System.Drawing.Common is part of WindowsDesktop shared framework but is not trimmed. The package will be downloaded even though it will not be used on .NET 10.0
Regression
No, missing functionality in a feature new to 10.0
Testing
Discovered this as part of comprehensive testing of #2254
Manually verified that this one addition fixes the remaining missing packages from pruning data for net10.
Risk
Low. Functionally this will not change anything since the package was removed by conflict resolution in build.
This change adds to pruning. There is a small chance that folks who don’t multitarget and have a direct reference to the package on net10.0 will see a pruning warning, but this is an actionable warning and consistent with all other packages that are part of shared framework (and introduced in .NET 10).
For those moving from a previous framework this will not be a new warning but will be part of the rest of the warnings they see.