@baronfel can you help resolve the conflict in this PR?

@premun I think I did it right ;)

The 6.0 aspnetcore ref pack is getting pulled in here due to this change in BrowserRefresh that changed the TFM to net6: https://github.com/dotnet/dotnet/pull/2334/files#diff-d31d6383bf312e730cb56afa2ab5e0eff0df03be7229dcbc7e3ec308149fb29aR3-R7. @tmat @MichaelSimons This was removed from SBRP, and would need to get added back.

Why are we targeting net6 though? Doesn't this imply that we are supporting something running on an out of support product?

Hot Reload supports net6.0+ apps. See https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2559220

I'm adding the targeting pack back: dotnet/source-build-reference-packages#1365

could we instead target net8.0 just for source-build?

could we instead target net8.0 just for source-build?

It would be preferrable to avoid diverging the SB behavior as we are trying to eliminate differences in SB.

Can we get this merged? its delaying maui/iOS/android to get the flow as it breaks our builds

Blocked by #2354 which is set to auto-merge.

Took a look at the VMR source-only build error:

The stirng.format is failing because there's an invalid property sneaking in on the .NET 10 ASpNetCore.App framework reference - the RuntimePackRuntimeIdentifiers is an MSBuild property string, not the actual resolved value

The SDK has a Directory.Build.targets that is setting a number of properties on the aspnetcore known frameworkreference:

  <ItemGroup Condition="$(MicrosoftAspNetCoreAppRefPackageVersion.StartsWith('$(_TargetFrameworkVersionWithoutV)'))">
    <KnownFrameworkReference Update="Microsoft.AspNetCore.App">
      <LatestRuntimeFrameworkVersion>$(MicrosoftAspNetCoreAppRefPackageVersion)</LatestRuntimeFrameworkVersion>
      <RuntimePackRuntimeIdentifiers>${SupportedRuntimeIdentifiers}</RuntimePackRuntimeIdentifiers>
      <TargetingPackVersion>$(MicrosoftAspNetCoreAppRefPackageVersion)</TargetingPackVersion>
      <DefaultRuntimeFrameworkVersion>$(MicrosoftAspNetCoreAppRefPackageVersion)</DefaultRuntimeFrameworkVersion>
    </KnownFrameworkReference>
  </ItemGroup>

it looks like a typo - need () here.

I changed it - but that change has been in for like 2 years - surely something else is going on here.

Interesting. We haven't seen this in #2352 which should have the equivalent changes

I looked at the binlog from #2352 and it does have the same typo issue there, but it doesn't cause the ProcessFrameworkReferences failure for some reason.