Add Winforms PackageOverrides to WindowsDesktop #2297
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
That's interesting - I would have expected that we needed a full transport pack on linux since it has the references that go into the targeting pack, however I see all the references are conditioned out: |
Member
Author
|
I guess we're not including the WindowsDesktop targeting pack in the SDK on linux. I'll update the condition here. |
akoeplinger
approved these changes
Sep 8, 2025
Member
Author
|
/backport to release/10.0.1xx |
Contributor
|
Started backporting to release/10.0.1xx: https://github.com/dotnet/dotnet/actions/runs/17618330091 |
Contributor
|
@ericstj backporting to "release/10.0.1xx" failed, the patch most likely resulted in conflicts: $ git am --3way --empty=keep --ignore-whitespace --keep-non-patch changes.patch
Applying: Add props file to transport package with packages and versions
Using index info to reconstruct a base tree...
M src/winforms/eng/Version.Details.props
M src/winforms/eng/Version.Details.xml
Falling back to patching base and 3-way merge...
Auto-merging src/winforms/eng/Version.Details.props
CONFLICT (content): Merge conflict in src/winforms/eng/Version.Details.props
Auto-merging src/winforms/eng/Version.Details.xml
CONFLICT (content): Merge conflict in src/winforms/eng/Version.Details.xml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 Add props file to transport package with packages and versions
Error: The process '/usr/bin/git' failed with exit code 128Please backport manually! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes dotnet/windowsdesktop#5244