Skip to content

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Sep 4, 2025

Backport of #2234 to release/10.0.1xx

/cc @ericstj

@ericstj ericstj requested a review from ViktorHofer September 4, 2025 02:27
@akoeplinger akoeplinger merged commit fb249dc into release/10.0.1xx Sep 4, 2025
10 checks passed
@akoeplinger akoeplinger deleted the backport/pr-2234-to-release/10.0.1xx branch September 4, 2025 08:35
@ViktorHofer
Copy link
Member

I wasn't merging the PR as I was assuming that this needs an ask-mode template / tell-mode ping.

@akoeplinger
Copy link
Member

ah I see, I assumed these were already handled since we normally don't deal with them in the VMR

@ericstj
Copy link
Member

ericstj commented Sep 4, 2025

I will send mail, was planning on marking it but I hit a road block since this repo didn't have the labels / template.

I did this in the VMR because I wanted to react to any breaks that might have happened due to pruning warnings if we had direct references. Thankfully we did not.

@ViktorHofer
Copy link
Member

We should probably add the labels and add this repo to tacticsview.

@ericstj
Copy link
Member

ericstj commented Sep 11, 2025

I was surprised that hadn't been done yet for this repo. It looks like it still wasn't set up, so I took care of it for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants