Skip to content

SignType variables must be lowercase #1948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ellahathaway merged 1 commit into from
Aug 18, 2025
Merged

SignType variables must be lowercase #1948

ellahathaway merged 1 commit into from
Aug 18, 2025

Conversation

@ellahathaway
Copy link
Member

@ellahathaway ellahathaway commented Aug 18, 2025 •
edited
Loading

Arcade expects these values to be lowercase, when they are not, conditions that check the DotNetSignType value evaluate to false.

As explained in #1949, this doesn't affect real signing, but it does affect test signing.

@ellahathaway ellahathaway requested review from a team as code owners August 18, 2025 17:10
@ellahathaway ellahathaway requested a review from mmitche August 18, 2025 17:11
@wtgodbe
Copy link
Member

wtgodbe commented Aug 18, 2025

Do we need this in the 10.0 branches?

@ellahathaway ellahathaway mentioned this pull request Aug 18, 2025
Closed
@ellahathaway
Copy link
Member Author

ellahathaway commented Aug 18, 2025 •
edited
Loading

Do we need this in the 10.0 branches?

Yeah, we should fix this in 10.0. I'll open a backport PR

@ellahathaway
Copy link
Member Author

ellahathaway commented Aug 18, 2025

/backport to release/10.0.1xx

@github-actions
Copy link
Contributor

github-actions bot commented Aug 18, 2025

Started backporting to release/10.0.1xx: https://github.com/dotnet/dotnet/actions/runs/17047586393

@github-actions github-actions bot mentioned this pull request Aug 18, 2025
Merged
@wtgodbe
Copy link
Member

wtgodbe commented Aug 18, 2025

Do we need RC1 as well?

@ellahathaway
Copy link
Member Author

ellahathaway commented Aug 18, 2025 •
edited
Loading

Do we need RC1 as well?

This only affects our ability to run test signing (#1758) and the signing of the SB artifacts (#1811) when the Signed (Real) pipeline parameter is passed for a manual pipeline run. I don't expect either to go into RC1. I think that if there's a need later, we can backport at that time.

@ellahathaway ellahathaway enabled auto-merge (squash) August 18, 2025 18:29
@ellahathaway ellahathaway merged commit 17b7225 into dotnet:main Aug 18, 2025
11 checks passed
@NikolaMilosavljevic
Copy link
Member

NikolaMilosavljevic commented Aug 18, 2025

Presumably DryRun case was not affected - should that be updated to all lowercase for consistency?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ViktorHofer ViktorHofer ViktorHofer approved these changes

@mmitche mmitche Awaiting requested review from mmitche

Assignees

No one assigned

Labels

None yet

Projects

.NET Unified Build
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ellahathaway @wtgodbe @NikolaMilosavljevic @ViktorHofer