Use SB artifacts RID#1910
Merged
Merged
Conversation
MichaelSimons
approved these changes
Aug 15, 2025
MichaelSimons
left a comment
MichaelSimons
left a comment
Member
There was a problem hiding this comment.
Can you make sure an issue is opened to track the release pipeline publishing cleanup?
This was referenced Aug 19, 2025
Member
Author
|
Member
Author
|
/backport to release/10.0.1xx |
Contributor
|
Started backporting to release/10.0.1xx: https://github.com/dotnet/dotnet/actions/runs/17623072723 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contributes to #1011
To support non-1xx feature bands for source-only builds, the prep script downloads the SB artifacts that came were produced from the corresponding 1xx build. This is known as the shared components artifacts tarball.
However, the logic to determine the URL from which to download this tarball is incorrect. The filename contains the RID value. The script is using Arcade scripts to get the RID but that RID doesn't align with the RID defined in the tarball. The RID for the tarball is actually defined by the pipeline (example). To fix this, we need to align with the RID being used by the pipeline.
The prep script already happens to have an
artifactsRidoption. But that applies to the downloading of the PSB artifacts, which today is only ever valid to use thecentos.<version>-x64RID since that is the only artifacts tarball we publish from where this downloads from. So, without any other changes, settingartifactsRidwouldn't work in cases likealmalinux.8-x64.Instead, we can consolidate the manner in which we retrieve SB artifacts between PSB and shared components. Today these are referenced in different ways. PSB artifacts get published as part of the SB release process and referenced from
https://builds.dotnet.microsoft.com/source-built-artifacts/assets. And shared components artifacts are published via Arcade from VMR builds and are referenced fromhttps://ci.dot.net/public/source-build.These changes align the reference of the artifacts so that we always consume the artifacts published by Arcade at
https://ci.dot.net/public/source-build. This allowsartifactsRidto be set in all cases and be able to retrieve the corresponding tarball for both PSB and shared components.Furthermore, this means that SB artifact publishing can be removed from the SB release process as these won't be consumed anymore.