Skip to content

[main] Source code updates from microsoft/vstest #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
premun merged 8 commits into from
Aug 20, 2025
Merged

[main] Source code updates from microsoft/vstest #1887

premun merged 8 commits into from
Aug 20, 2025

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 14, 2025 •
edited
Loading

Note

This is a codeflow update. It may contain both source code changes from the source repo as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/microsoft/vstest

@dotnet-maestro
Copy link
Contributor Author

dotnet-maestro bot commented Aug 14, 2025

Notification for subscribed users from https://github.com/microsoft/vstest:

@dotnet/testing-admin

Action requested: Please take a look at this failing automated dependency-flow pull request's checks; failures may be related to changes which originated in your repo.

akoeplinger
akoeplinger reviewed Aug 14, 2025
View reviewed changes
@ViktorHofer
Copy link
Member

ViktorHofer commented Aug 19, 2025 •
edited
Loading

@nohwnd this is still failing, unfortunately. If you want to, you can try a fix directly in this PR. Note that this also blocks microsoft/vstest@9cbffb0 getting into the VMR which as I just heard in Tactics is important to get in.

After this main PR is merged, I will cherry-pick the additional fixes into the rc1 PR.

@ViktorHofer ViktorHofer mentioned this pull request Aug 19, 2025
Merged
@nohwnd
Copy link
Member

nohwnd commented Aug 20, 2025

@ViktorHofer thanks for the breakdown, this PR fails because the source code did not update (yet?). RC1 PR has all the needed changes correctly propagated.

nohwnd
nohwnd reviewed Aug 20, 2025
View reviewed changes
premun
premun requested changes Aug 20, 2025
View reviewed changes
Copy link
Member

@premun premun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me verify if this is mergeable even through the failing check

premun
premun approved these changes Aug 20, 2025
View reviewed changes
Copy link
Member

@premun premun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The source files match the SHA in the source-manifest so we can merge. I will try to see why it thinks it applied the new build while it hasn't

@premun premun merged commit f92667c into main Aug 20, 2025
14 of 15 checks passed
@premun premun deleted the darc-main-d114dfc8-15d5-44ed-8124-ec0952b07892 branch August 20, 2025 15:23
@premun premun mentioned this pull request Aug 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akoeplinger akoeplinger akoeplinger left review comments

@ViktorHofer ViktorHofer ViktorHofer left review comments

@premun premun premun approved these changes

+1 more reviewer

@nohwnd nohwnd nohwnd left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

.NET Unified Build
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ViktorHofer @nohwnd @akoeplinger @premun