Skip to content

[main] Source code updates from dotnet/source-build-reference-packages #1835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dotnet-maestro wants to merge 2 commits into from
Closed

[main] Source code updates from dotnet/source-build-reference-packages #1835

dotnet-maestro wants to merge 2 commits into from

Conversation

@dotnet-maestro
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Aug 11, 2025

Note

This is a codeflow update. It may contain both source code changes from the source repo as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/dotnet/source-build-reference-packages

@tannergooding
Copy link
Member

tannergooding commented Aug 11, 2025

@dotnet/source-build seems there's a failure here:

[xUnit.net 00:00:19.27]         Did not find PDBs for the following SDK files:
[xUnit.net 00:00:19.27]         /__w/1/s/artifacts/obj/extracted-dotnet-sdk/sdk/10.0.100-ci/DotnetTools/dotnet-watch/10.0.100-ci/tools/net10.0/any/BuildHost-netcore/Microsoft.Build.Locator.dll
[xUnit.net 00:00:19.27]         /__w/1/s/artifacts/obj/extracted-dotnet-sdk/sdk/10.0.100-ci/DotnetTools/dotnet-format/BuildHost-netcore/Microsoft.Build.Locator.dll
[xUnit.net 00:00:19.27]         /__w/1/s/artifacts/obj/extracted-dotnet-sdk/sdk/10.0.100-ci/DotnetTools/dotnet-watch/10.0.100-ci/tools/net10.0/any/Microsoft.Build.Locator.dll

Is something else required here to get the PDBs in sync? This is just pulling in the dotnet/sbrp update of MSBuildLocator from 1.6.10 to 1.8.1

@ellahathaway
Copy link
Member

ellahathaway commented Aug 11, 2025

Is something else required here to get the PDBs in sync? This is just pulling in the dotnet/sbrp update of MSBuildLocator from 1.6.10 to 1.8.1

This PR needs to be combined with #1763. I'm going to close this PR and migrate the changes.

@tannergooding
Copy link
Member

tannergooding commented Aug 11, 2025

Thanks so much!

@dotnet-maestro dotnet-maestro bot deleted the darc-main-dd4e5b2f-3a67-4ad7-aeb4-cff3a1d45d84 branch August 11, 2025 20:52
@ellahathaway ellahathaway restored the darc-main-dd4e5b2f-3a67-4ad7-aeb4-cff3a1d45d84 branch August 11, 2025 21:50
@ellahathaway ellahathaway mentioned this pull request Aug 11, 2025
Closed
@premun premun deleted the darc-main-dd4e5b2f-3a67-4ad7-aeb4-cff3a1d45d84 branch September 10, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mmitche mmitche mmitche approved these changes

Assignees

No one assigned

Labels

None yet

Projects

.NET Unified Build
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@tannergooding @ellahathaway @mmitche