-
Notifications
You must be signed in to change notification settings - Fork 228
[TEST] Bumping maintenance-packages dependencies in repos that depend on them #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
carlossanlop
wants to merge
49
commits into
dotnet:main
from
carlossanlop:BumpMaintenancePackagesDependencies
Closed
Changes from all commits
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
660b8f9
runtime - System.ValueTuple and System.Runtime.CompilerServices.Unsafe
carlossanlop 878dfc0
aspnetcore - System.ValueTuple
carlossanlop 23f86bf
fsharp - System.ValueTuple and System.Runtime.CompilerServices.Unsafe
carlossanlop e3f555d
msbuild - System.Runtime.CompilerServices.Unsafe
carlossanlop 8dc91d1
roslyn - System.Runtime.CompilerServices.Unsafe (broke after updating…
carlossanlop 53bde9a
fsharp - Add missing dotnet-libraries feed to NuGet.config
carlossanlop 1f0d3af
aspnetcore - Add missing dotnet-libraries feed to NuGet.config
carlossanlop 98e9af4
efcore - Add missing dotnet-libraries feed to NuGet.config
carlossanlop e31b694
razor - System.ValueTuple and System.Runtime.CompilerServices.Unsafe
carlossanlop 215405a
efcore - System.Runtime.CompilerServices.Unsafe
carlossanlop 3a51ec3
aspnetcore - System.ValueTuple and System.Runtime.CompilerServices.Un…
carlossanlop e12125d
wpf - NuGet.config
carlossanlop 6f73b45
wpf - System.Runtime.CompilerServices.Unsafe
carlossanlop 1fa1ccf
Merge branch 'main' into BumpMaintenancePackagesDependencies
carlossanlop 7659dbb
razor - Add missing dotnet-libraries feed to NuGet.config
carlossanlop 09a6ed1
Merge branch 'main' into BumpMaintenancePackagesDependencies
carlossanlop 7356fda
aspnetcore - Revert all
carlossanlop d987374
aspnetcore - NuGet feed, ValueTuple and CompilerServices.Unsafe
carlossanlop e435dbb
runtime - Conditionally update ValueTuple and CompilerServicesUnsafe
carlossanlop 71f65f7
Merge branch 'main' into BumpMaintenancePackagesDependencies
carlossanlop 65e2f6e
source-build-reference-packages: Generate S.ValueTuple and S.R.CS.Unsafe
carlossanlop b491c25
aspnetcore - Remove conditions
carlossanlop 360f954
runtime - Remove conditions
carlossanlop 1ac08c4
Merge remote-tracking branch 'origin/BumpMaintenancePackagesDependenc…
carlossanlop 7f9f450
windowsdesktop - System.Runtime.CompilerServices.Unsafe Versions.props
carlossanlop 4a064e3
windowsdesktop - Revert Versions.props
carlossanlop e0ede67
windowsdesktop - Add feed
carlossanlop 5c3f3eb
Remove all dotnet-libraries feeds
carlossanlop 337917d
Merge branch 'main' into BumpMaintenancePackagesDependencies
carlossanlop 344496d
fsharp - Conditioned
carlossanlop 9c95539
Merge branch 'BumpMaintenancePackagesDependencies' of https://github.…
carlossanlop 95a5403
SBRP - nuget feed
carlossanlop 616e3c4
SBRP - eng/Build.props S.R.CS.Unsafe
carlossanlop 49e8e63
Merge branch 'BumpMaintenancePackagesDependencies' of https://github.…
carlossanlop dc2bc38
efcore - Nuget feed
carlossanlop 8dc0eff
fsharp - nuget feed
carlossanlop 9894aab
razor - nuget feed
carlossanlop 4e624f3
wpf - nuget feed
carlossanlop 4055e94
aspnetcore - dotnet-libraries feed to NuGet.config
carlossanlop 3bc218f
Merge branch 'main' into BumpMaintenancePackagesDependencies
carlossanlop faeff71
windowsdesktop - Add nuget feed
carlossanlop bb16008
Merge branch 'BumpMaintenancePackagesDependencies' of https://github.…
carlossanlop 243535c
Merge branch 'main' into BumpMaintenancePackagesDependencies
carlossanlop ede249f
Remove the razor s.r.cs.unsafe dependency
carlossanlop 9eb504a
Merge remote-tracking branch 'dotnet/main' into BumpMaintenancePackag…
carlossanlop ccccd03
aspnetcore
carlossanlop c6dce27
Update all feeds and package versions to use the m-p latest feed
carlossanlop 4d9f8bf
Razor change is needed, bring it back
carlossanlop 4e8e8d0
Missing feed in msbuild
carlossanlop File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
...ices.unsafe/6.1.1-rtm.final/System.Runtime.CompilerServices.Unsafe.6.1.1-rtm.final.csproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <TargetFrameworks>net6.0;netstandard2.0</TargetFrameworks> | ||
| <AssemblyName>System.Runtime.CompilerServices.Unsafe</AssemblyName> | ||
| </PropertyGroup> | ||
|
|
||
| </Project> |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ericstj from your comment: #133 (comment)
Already updated it here, but conditioned to source build.
I do see a bunch of csprojs in aspnet core that are hardcoding System.ValueTuple, instead of using the property value.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Those projects aren't the ones casing the failure.
Why is it OK to condition it on source build if you haven't conditioned it on source build in runtime? Runtime has the newer reference, which comes in transitively then ASPNET project is downgrading it.