Skip to content

[TEST] Bumping maintenance-packages dependencies in repos that depend on them #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
carlossanlop wants to merge 49 commits into from
Closed

[TEST] Bumping maintenance-packages dependencies in repos that depend on them #133

carlossanlop wants to merge 49 commits into from

Conversation

@carlossanlop
Copy link
Contributor

@carlossanlop carlossanlop commented Jan 15, 2025 •
edited
Loading

DO NOT MERGE.

This PR intends to verify which repos need to get the dependencies updated after runtime gets them updated first.

@carlossanlop carlossanlop changed the title [TEST] Testing bumping maintenance-packages dependencies in repos that depend on them [TEST] Bumping maintenance-packages dependencies in repos that depend on them Jan 15, 2025
@carlossanlop carlossanlop mentioned this pull request Jan 16, 2025
Merged
1 task
@carlossanlop
aspnetcore - Add missing dotnet-libraries feed to NuGet.config
1f0d3af
@carlossanlop
efcore - Add missing dotnet-libraries feed to NuGet.config
98e9af4
@carlossanlop
razor - System.ValueTuple and System.Runtime.CompilerServices.Unsafe
e31b694
@carlossanlop
efcore - System.Runtime.CompilerServices.Unsafe
215405a
@carlossanlop
aspnetcore - System.ValueTuple and System.Runtime.CompilerServices.Un…
3a51ec3 
…safe
@carlossanlop
wpf - NuGet.config
e12125d
@carlossanlop
wpf - System.Runtime.CompilerServices.Unsafe
6f73b45
@carlossanlop
Merge branch 'main' into BumpMaintenancePackagesDependencies
1fa1ccf
@carlossanlop
razor - Add missing dotnet-libraries feed to NuGet.config
7659dbb
@carlossanlop
Merge branch 'main' into BumpMaintenancePackagesDependencies
09a6ed1
@carlossanlop
aspnetcore - Revert all
7356fda
@carlossanlop
aspnetcore - NuGet feed, ValueTuple and CompilerServices.Unsafe
d987374
@carlossanlop
runtime - Conditionally update ValueTuple and CompilerServicesUnsafe
e435dbb
@carlossanlop
Merge branch 'main' into BumpMaintenancePackagesDependencies
71f65f7
@carlossanlop
Copy link
Contributor Author

carlossanlop commented Jan 28, 2025

@dotnet/source-build do you know if there is a known issue for a segmentation fault in the creation of the binlog of this leg? https://github.com/dotnet/dotnet/pull/133/checks?check_run_id=36255542155

This was referenced Feb 4, 2025
Closed
Merged
Merged
This was referenced Feb 18, 2025
Closed
Merged
carlossanlop
carlossanlop commented Feb 18, 2025
View reviewed changes
This was referenced Feb 18, 2025
Merged
Merged
Closed
Closed
@carlossanlop carlossanlop mentioned this pull request Feb 18, 2025
Merged
@carlossanlop
Copy link
Contributor Author

carlossanlop commented Feb 19, 2025

I was hoping that changing to the internal feed for m-p would let me use the regular package version but no. I'll have to keep using the ugly one with the suffix.

@ericstj
Copy link
Member

ericstj commented Feb 19, 2025

Stuff seems to be working.

src/aspnetcore/src/Testing/src/Microsoft.AspNetCore.InternalTesting.csproj#L0

src/aspnetcore/src/Testing/src/Microsoft.AspNetCore.InternalTesting.csproj(0,0): error NU1605: (NETCORE_ENGINEERING_TELEMETRY=Restore) Warning As Error: Detected package downgrade: System.ValueTuple from 4.6.0 to 4.5.0. Reference the package directly from the project to select a different version. 
 Microsoft.AspNetCore.InternalTesting -> Microsoft.Extensions.Logging 10.0.0-ci -> System.ValueTuple (>= 4.6.0) 
 Microsoft.AspNetCore.InternalTesting -> System.ValueTuple (>= 4.5.0)

Looks to me like aspnetcore needs an update since it's adding a direct dependency on the old version of ValueTuple.

@ericstj
Copy link
Member

ericstj commented Feb 19, 2025

Seems you need to update https://github.com/dotnet/aspnetcore/blob/48d9b829994babfe386087f965b5a3a6a2af9ebd/eng/Versions.props#L225

carlossanlop
carlossanlop commented Feb 19, 2025
View reviewed changes
src/aspnetcore/eng/Versions.props
<MicrosoftBCLHashCodeVersion>6.0.0</MicrosoftBCLHashCodeVersion>
<SystemBuffersVersion>4.6.0</SystemBuffersVersion>
<SystemThreadingTasksExtensionsVersion>4.6.0</SystemThreadingTasksExtensionsVersion>
<SystemValueTupleVersion>4.6.0</SystemValueTupleVersion>
Copy link
Contributor Author

@carlossanlop carlossanlop Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ericstj from your comment: #133 (comment)

Already updated it here, but conditioned to source build.

I do see a bunch of csprojs in aspnet core that are hardcoding System.ValueTuple, instead of using the property value.

  • eng/Baseline.Designer.props
  • src/submodules/MessagePack-CSharp/sandbox/...
    • TestData.InvalidProject.csproj
    • TestData.InvalidSyntax.csproject
    • TestData2.csproj

Copy link
Member

@ericstj ericstj Feb 19, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those projects aren't the ones casing the failure.

Why is it OK to condition it on source build if you haven't conditioned it on source build in runtime? Runtime has the newer reference, which comes in transitively then ASPNET project is downgrading it.

@carlossanlop
Copy link
Contributor Author

carlossanlop commented Feb 21, 2025

Replaced with #155

@carlossanlop carlossanlop deleted the BumpMaintenancePackagesDependencies branch February 21, 2025 01:47
carlossanlop added a commit to dotnet/roslyn that referenced this pull request Mar 25, 2025
@carlossanlop
Update maintenance-packages dependencies (#77267)
3382aa6 
This PR is result of testing the parallel dependency updates to ensure
source-build does not break: dotnet/dotnet#133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericstj ericstj ericstj left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@carlossanlop @ericstj