You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 578d965
Browse filesBrowse the repository at this point in the historyBrowse files
Copy file name to clipboardExpand all lines: src/runtime/.github/policies/resourceManagement.yml
+14Lines changed: 14 additions & 0 deletions
Original file line number
Diff line number
Diff line change
@@ -198,6 +198,8 @@ configuration:
198
198
label: area-Microsoft.Win32
199
199
- labelAdded:
200
200
label: area-NativeAOT-coreclr
201
+
- labelAdded:
202
+
label: area-ReadyToRun
201
203
- labelAdded:
202
204
label: area-Single-File
203
205
- labelAdded:
@@ -791,6 +793,18 @@ configuration:
791
793
See info in [area-owners.md](https://github.com/dotnet/runtime/blob/main/docs/area-owners.md) if you want to be subscribed.
792
794
assignMentionees: False
793
795
- if:
796
+
- hasLabel:
797
+
label: area-ReadyToRun
798
+
then:
799
+
- mentionUsers:
800
+
mentionees:
801
+
- dotnet/crossgen-contrib
802
+
replyTemplate: >-
803
+
Tagging subscribers to this area: ${mentionees}
804
+
805
+
See info in [area-owners.md](https://github.com/dotnet/runtime/blob/main/docs/area-owners.md) if you want to be subscribed.
Copy file name to clipboardExpand all lines: src/runtime/.github/skills/code-review/SKILL.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -35,7 +35,7 @@ Before analyzing anything, collect as much relevant **code** context as you can.
35
35
6.**Git history**: Check recent commits to the changed files (`git log --oneline -20 -- <file>`). Look for related recent changes, reverts, or prior attempts to fix the same problem. This reveals whether the area is actively churning, whether a similar fix was tried and reverted, or whether the current change conflicts with recent work.
36
36
7.**Detect new public API surface**: Check whether the PR introduces new public API surface. Look for:
37
37
- Changes to `ref/` assembly source files (the strongest signal — these define the public API contract)
38
-
- New `public` members (methods, properties, types, enum values) in `src/` files
38
+
- New `public` members (methods, properties, types, enum values) in `src/` files under src/libraries directory. In particular files under various `tools/` subdirectories are tools, and their APIs are not public APIs even if they may be `public` in C# source code.
39
39
- Note whether new public API was detected. If it was, you **MUST** load and execute the API approval verification procedure during Step 4. Read the file `.github/skills/code-review/api-approval-check.md` (relative to the repository root) and follow its instructions. Do not skip this step — it is blocking.
Copy file name to clipboardExpand all lines: src/runtime/eng/Subsets.props
+3-3Lines changed: 3 additions & 3 deletions
Original file line number
Diff line number
Diff line change
@@ -752,10 +752,10 @@
752
752
</ItemGroup>
753
753
<ItemGroup>
754
754
<!--
755
-
When we're building in the VMR, we need to provide a crossgen2 that runs on the host machine for downstream repos to use to R2R their code.
756
-
In non-VMR builds, downstream repos can use the crossgen2 built for the target host SDK from another build leg, but in the VMR we need to provide one to use.
755
+
When BuildHostTools is enabled, we need to provide a crossgen2 that runs on the host machine for downstream repos to use to R2R their code.
756
+
Non-VMR builds normally use the crossgen2 built for the target host SDK from another build leg, but builds without one can opt in.
757
757
-->
758
-
<ProjectToBuildCondition="'$(RuntimeFlavor)' != 'Mono' and '$(TargetsMobile)' != 'true' and '$(TargetsLinuxBionic)' != 'true' and '$(BuildHostTools)' == 'true'"Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Crossgen2.Host.sfxproj"Category="packs" />
758
+
<ProjectToBuildCondition="'$(RuntimeFlavor)' != 'Mono' and ('$(TargetsMobile)' != 'true' or '$(TargetOS)' == 'browser') and '$(TargetsLinuxBionic)' != 'true' and '$(BuildHostTools)' == 'true'"Include="$(InstallerProjectRoot)pkg\sfx\Microsoft.NETCore.App\Microsoft.NETCore.App.Crossgen2.Host.sfxproj"Category="packs" />
0 commit comments