Skip to content

Commit 082832b

Browse files
[main] Source code updates from dotnet/sdk (#9000)
Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com>
1 parent 7f39870 commit 082832b

384 files changed

Lines changed: 186539 additions & 173873 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎src/sdk/.config/dotnet-tools.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
"isRoot": true,
44
"tools": {
55
"microsoft.dotnet.helix.jobmonitor": {
6-
"version": "11.0.0-beta.26427.10",
6+
"version": "11.0.0-beta.26451.109",
77
"commands": [
88
"dotnet-helix-job-monitor"
99
]

‎src/sdk/.github/memory/CONVENTIONS.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ Repository policy:
6262

6363
| Subject | Canonical source |
6464
| --- | --- |
65-
| Hard guardrails, CI telemetry, and generated files | [Root instructions](../copilot-instructions.md#guardrails) |
65+
| Hard guardrails, CI telemetry, and generated files | [Root instructions](../../AGENTS.md#guardrails) |
6666
| Repository build properties and analyzer configuration | [`Directory.Build.props`](../../Directory.Build.props), [`Directory.Build.targets`](../../Directory.Build.targets), [`.editorconfig`](../../.editorconfig) |
6767
| CLI commands and AOT constraints | [`src/Cli/AGENTS.md`](../../src/Cli/AGENTS.md) and CLI skills |
6868
| MSBuild tasks, targets, diagnostics, and framework compatibility | [`src/Tasks/AGENTS.md`](../../src/Tasks/AGENTS.md) |

‎src/sdk/.github/memory/FILE_MAP.md‎

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,14 +19,16 @@ and [`CODEOWNERS`](../../CODEOWNERS) is the ownership source of truth.
1919
| [`build/`](../../build) | Repository-specific build targets and generated-resource support. | Imported from root `Directory.Build.*`. |
2020
| [`scripts/`](../../scripts) | Repository maintenance and evaluation utilities, including conditional-test selection. | Used by developers, agents, and CI. |
2121
| [`documentation/`](../../documentation) | Contributor and subsystem documentation. Start with the [Developer Guide](../../documentation/project-docs/developer-guide.md). | Must remain synchronized with product and workflow changes. |
22-
| [`.github/`](..) | GitHub workflows, agent instructions, agents, skills, and memory. | Guides GitHub automation and AI-assisted development. |
22+
| [`.github/`](..) | GitHub workflows, agents, skills, and memory. | Guides GitHub automation and AI-assisted development. |
2323
| [`.azuredevops/`](../../.azuredevops), [`eng/pipelines`](../../eng/pipelines) | Azure DevOps pipeline entry points and shared templates. | Build and submit tests to Helix. |
2424
| [`benchmarks/`](../../benchmarks) | Performance benchmarks for selected components. | Consumes product projects; not part of routine targeted validation. |
2525
| `.dotnet/` | Repository-local SDK restored by the build. Invoke `.dotnet/dotnet` (`.dotnet\dotnet.exe` on Windows) when a command should resolve with the repository bootstrap SDK. | Selected by [`global.json`](../../global.json); not a product output or the SDK exercised by product tests. |
2626
| `artifacts/` | Generated build, package, log, test, and redist outputs; never source-controlled. | Recreated by builds. |
2727

2828
Important root files:
2929

30+
- [`AGENTS.md`](../../AGENTS.md): repository-wide agent instructions; nearer `AGENTS.md`
31+
files add area-specific guidance.
3032
- [`build.cmd`](../../build.cmd) / [`build.sh`](../../build.sh): full Arcade build entry points.
3133
- [`test.cmd`](../../test.cmd) / [`test.sh`](../../test.sh) and
3234
[`restore.cmd`](../../restore.cmd) / [`restore.sh`](../../restore.sh): thin wrappers

‎src/sdk/.github/memory/KNOWN_ISSUES.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -75,7 +75,7 @@ creates `*.received.*` files on mismatch that must not be committed.
7575
**Workaround:** Edit `.resx` and regenerate XLF; change manpage content in `dotnet/docs`;
7676
regenerate workflow locks through their owning workflow; inspect received snapshots and
7777
promote only intentional output to `*.verified.*`. See the
78-
[root generated-file guardrails](../copilot-instructions.md#do-not-hand-edit-generated-files)
78+
[root generated-file guardrails](../../AGENTS.md#do-not-hand-edit-generated-files)
7979
and [`snapshot-based-testing.md`](../../documentation/project-docs/snapshot-based-testing.md).
8080

8181
## Redist Requires Correct Outer-Build Ordering

‎src/sdk/.github/memory/TESTING_STRATEGY.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ are colocated under
1919
| Shared test harness | [`test/Microsoft.NET.TestFramework.MSTest`](../../test/Microsoft.NET.TestFramework.MSTest) |
2020
| Configured PR test scopes and trigger paths | [`test/ConditionalTests.props`](../../test/ConditionalTests.props) |
2121
| Conditional-filtering design and maintenance | [`pr-test-filtering.md`](../../documentation/project-docs/pr-test-filtering.md) |
22-
| Full repository build and suite | [Root instructions](../copilot-instructions.md#build-and-test) and [Developer Guide](../../documentation/project-docs/developer-guide.md#running-tests) |
22+
| Full repository build and suite | [Root instructions](../../AGENTS.md#build-and-test) and [Developer Guide](../../documentation/project-docs/developer-guide.md#running-tests) |
2323
| Helix publishing and partitioning | [`test/UnitTests.proj`](../../test/UnitTests.proj) |
2424
| Reproducing a Helix layout locally | [`repro-helix-failure.md`](../../documentation/project-docs/repro-helix-failure.md) |
2525

‎src/sdk/.github/skills/code-review/SKILL.md‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -188,8 +188,8 @@ Only flag **actual problems**. Every comment must identify a concrete issue. Cat
188188
12. **Missing error handling at system boundaries** — unvalidated external input or missing null checks at public/internal API entry points. Do NOT flag null checks for parameters the type system already guarantees non-null.
189189
13. **Resource leaks** — `IDisposable` objects (e.g., `CancellationTokenSource`, `SemaphoreSlim`, process handles) created but never disposed, even if the pattern was moved from elsewhere.
190190
14. **Documentation & explanatory comments for non-obvious SDK behavior** — subtle target/property decisions, runtime mapping, or cross-repo ownership boundaries that a future maintainer cannot infer from types or names and that lack a durable comment; stale comments that contradict the code; workaround comments without a tracking link.
191-
15. **Repository convention violations** — the change breaks a rule documented in the [repository guardrails](../../copilot-instructions.md#guardrails) or the nearest area `AGENTS.md`. Read those files (they govern the directories being changed) and flag violations the build won't already catch — for example, hand-editing generated or regenerated files, or fixing behavior in this repo that another repo owns.
192-
16. **Stale or ungrounded AI context / instructions / docs** — the change makes something an AI- or contributor-facing artifact says no longer true: a documented command, file path or location, guardrail, build/test workflow, convention, or architecture description that the change has invalidated (for example, moving or renaming a file that a doc references), and that artifact wasn't updated in the same PR. Also flag newly added or materially changed important claims about architecture, product behavior, or ownership when they lack a durable primary-source link (code or project files, an ADR or design document, or an issue or PR). Flag citations that do not support the claim and inferences presented as established facts. Name the exact artifact — `.github/copilot-instructions.md`, `.github/memory/*.md`, any `AGENTS.md` in an affected subdirectory, a `.github/skills/*/SKILL.md`, a `.claude/skills/*/SKILL.md`, a `.github/agents/*.agent.md`, or a file under `documentation/` — and the concrete drift or unsupported claim. Don't flag internal changes that no artifact describes, and don't demand citations for routine instructions or obvious code-local facts.
191+
15. **Repository convention violations** — the change breaks a rule documented in the [repository guardrails](../../../AGENTS.md#guardrails) or the nearest area `AGENTS.md`. Read those files (they govern the directories being changed) and flag violations the build won't already catch — for example, hand-editing generated or regenerated files, or fixing behavior in this repo that another repo owns.
192+
16. **Stale or ungrounded AI context / instructions / docs** — the change makes something an AI- or contributor-facing artifact says no longer true: a documented command, file path or location, guardrail, build/test workflow, convention, or architecture description that the change has invalidated (for example, moving or renaming a file that a doc references), and that artifact wasn't updated in the same PR. Also flag newly added or materially changed important claims about architecture, product behavior, or ownership when they lack a durable primary-source link (code or project files, an ADR or design document, or an issue or PR). Flag citations that do not support the claim and inferences presented as established facts. Name the exact artifact — the root or nearest area `AGENTS.md`, `.github/memory/*.md`, a `.github/skills/*/SKILL.md`, a `.claude/skills/*/SKILL.md`, a `.github/agents/*.agent.md`, or a file under `documentation/` — and the concrete drift or unsupported claim. Don't flag internal changes that no artifact describes, and don't demand citations for routine instructions or obvious code-local facts.
193193

194194
### What NOT to Flag
195195

‎src/sdk/.github/skills/update-docs/SKILL.md‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ renamed, or changes purpose. Its loading map must list exactly the files that ex
5353

5454
Review the affected area for:
5555

56-
- `.github/copilot-instructions.md` and the nearest `AGENTS.md`
56+
- the root and nearest area `AGENTS.md`
5757
- `.github/skills/*/SKILL.md`, `.claude/skills/*/SKILL.md`, and `.github/agents/*.agent.md`
5858
- contributor and area guidance under `documentation/`
5959
- command help, usage text, completion and Verify snapshots

‎src/sdk/.github/workflows/add-servicing-consider-label.yml‎

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@ on:
66
types: [opened, reopened, ready_for_review]
77
branches:
88
- 'release/[0-9]*'
9-
# ignore 10.0.4xx until we release it
10-
- '!release/10.0.4xx'
119

1210
permissions:
1311
contents: read
Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -11,14 +11,14 @@ shared between the .NET CLI and Visual Studio. The build output is a complete, r
1111
(`Debug` by default).
1212

1313
For a high-level project description, build status, and contribution flow, see the
14-
[README](../README.md). For the canonical build/test/debug walkthrough, see the
15-
[Developer Guide](../documentation/project-docs/developer-guide.md).
14+
[README](README.md). For the canonical build/test/debug walkthrough, see the
15+
[Developer Guide](documentation/project-docs/developer-guide.md).
1616

1717
### Agent orientation and memory
1818

19-
1. Read the [memory index](memory/INDEX.md) first and load other memory files on demand.
20-
2. For non-trivial work, also read [ARCHITECTURE.md](memory/ARCHITECTURE.md) and
21-
[CONVENTIONS.md](memory/CONVENTIONS.md).
19+
1. Read the [memory index](.github/memory/INDEX.md) first and load other memory files on demand.
20+
2. For non-trivial work, also read [ARCHITECTURE.md](.github/memory/ARCHITECTURE.md) and
21+
[CONVENTIONS.md](.github/memory/CONVENTIONS.md).
2222
3. Treat memory as orientation; cross-check important claims against linked primary sources.
2323
4. Correct stale memory in the same change and keep the index synchronized.
2424

@@ -40,25 +40,25 @@ root-cause analyses, and AI-facing documentation:
4040

4141
### What the SDK does
4242

43-
See [ARCHITECTURE.md](memory/ARCHITECTURE.md) for product components and data flow,
44-
[FILE_MAP.md](memory/FILE_MAP.md) for repository locations, and
45-
[API_MAP.md](memory/API_MAP.md) for user-facing and extension surfaces.
43+
See [ARCHITECTURE.md](.github/memory/ARCHITECTURE.md) for product components and data flow,
44+
[FILE_MAP.md](.github/memory/FILE_MAP.md) for repository locations, and
45+
[API_MAP.md](.github/memory/API_MAP.md) for user-facing and extension surfaces.
4646

4747
### Repository boundaries and the VMR
4848

4949
An SDK command or build can expose behavior implemented by another .NET repository. Find
5050
the component that defines the behavior before making a change; do not add an SDK
5151
workaround merely because the symptom appears through `dotnet`, and do not infer ownership
5252
from a diagnostic ID. See the canonical
53-
[ownership map](memory/ARCHITECTURE.md#ownership-boundaries).
53+
[ownership map](.github/memory/ARCHITECTURE.md#ownership-boundaries).
5454

5555
### Build and test
5656

5757
- Build the redist SDK with `build.cmd` on Windows or `./build.sh` on Linux/macOS.
5858
- Add `-test` / `--test` for the full suite and `-pack` / `--pack` for packages/installers;
5959
avoid these large operations in the routine inner loop.
60-
- Use [`run-tests` skill](skills/run-tests/SKILL.md) for focused validation and
61-
[`incremental-test` skill](skills/incremental-test/SKILL.md) for supported
60+
- Use [`run-tests` skill](.github/skills/run-tests/SKILL.md) for focused validation and
61+
[`incremental-test` skill](.github/skills/incremental-test/SKILL.md) for supported
6262
`dotnet.Tests` changes.
6363
- Product tests exercise `artifacts/bin/redist/<configuration>/dotnet`; ensure it contains
6464
the production change before trusting results.
@@ -87,8 +87,8 @@ Canonical scenarios:
8787
- Validate changes locally using the SDK you built at
8888
`artifacts/bin/redist/<configuration>/dotnet` (`Debug` by default).
8989

90-
See [TESTING_STRATEGY.md](memory/TESTING_STRATEGY.md) and the
91-
[Developer Guide](../documentation/project-docs/developer-guide.md).
90+
See [TESTING_STRATEGY.md](.github/memory/TESTING_STRATEGY.md) and the
91+
[Developer Guide](documentation/project-docs/developer-guide.md).
9292

9393
## Guardrails
9494

@@ -107,7 +107,7 @@ manually edit:
107107
- **`.xlf` localization files.** Change the source `.resx` strings instead, then
108108
regenerate the `.xlf` with the `/t:UpdateXlf` MSBuild target. Correctly regenerated
109109
entries have a state of `needs-review-translation` or `new`. See
110-
[Localization](../documentation/project-docs/Localization.md) for the full workflow.
110+
[Localization](documentation/project-docs/Localization.md) for the full workflow.
111111
- **Generated man pages** under `documentation/manpages/sdk`. These are generated from
112112
documentation; change the upstream documentation in https://github.com/dotnet/docs instead.
113113
- **Generated workflow lock files** (`.github/workflows/*.lock.yml`).
@@ -125,22 +125,22 @@ workflow. Use the applicable value without changes:
125125
`azdo-$(System.CollectionId)-$(System.TeamProjectId)-$(Build.BuildId)`
126126

127127
When you change shared CI environment variables, preserve this variable. See
128-
the [developer guide](../documentation/project-docs/developer-guide.md#ci-workflow-telemetry-correlation)
128+
the [developer guide](documentation/project-docs/developer-guide.md#ci-workflow-telemetry-correlation)
129129
for the required YAML and the reason for this variable.
130130

131131
## External Dependencies
132132

133133
Adding or updating a dependency is a repo-wide compatibility and supply-chain change.
134-
Follow [CONVENTIONS.md](memory/CONVENTIONS.md#dependency-management).
134+
Follow [CONVENTIONS.md](.github/memory/CONVENTIONS.md#dependency-management).
135135

136136
## Coding Style
137137

138-
Follow [CONVENTIONS.md](memory/CONVENTIONS.md) and the nearest area `AGENTS.md`.
138+
Follow [CONVENTIONS.md](.github/memory/CONVENTIONS.md) and the nearest area `AGENTS.md`.
139139

140140
### Target framework properties
141141

142142
Never hardcode the current TFM in a project. See
143-
[CONVENTIONS.md](memory/CONVENTIONS.md#framework-and-build-constraints).
143+
[CONVENTIONS.md](.github/memory/CONVENTIONS.md#framework-and-build-constraints).
144144

145145
## Testing
146146

@@ -152,13 +152,13 @@ Never hardcode the current TFM in a project. See
152152
unscoped common areas. Run one project, class, or method with detailed live output and
153153
retained TRX/binlog diagnostics.
154154
- For incremental test runs of `dotnet.Tests` (avoids slow full `build.cmd`), use the `incremental-test` skill.
155-
- Follow [`test/AGENTS.md`](../test/AGENTS.md) and
156-
[TESTING_STRATEGY.md](memory/TESTING_STRATEGY.md) for test framework, assets,
155+
- Follow [`test/AGENTS.md`](test/AGENTS.md) and
156+
[TESTING_STRATEGY.md](.github/memory/TESTING_STRATEGY.md) for test framework, assets,
157157
parallelism, conditional scopes, snapshots, and Helix guidance.
158158
- This repo uses conditional test filtering to skip expensive test suites on PRs when
159159
relevant source files have not changed. When adding new test projects, consider
160-
registering them as a scope in [`test/ConditionalTests.props`](../test/ConditionalTests.props).
161-
See [`documentation/project-docs/pr-test-filtering.md`](../documentation/project-docs/pr-test-filtering.md) for details.
160+
registering them as a scope in [`test/ConditionalTests.props`](test/ConditionalTests.props).
161+
See [`documentation/project-docs/pr-test-filtering.md`](documentation/project-docs/pr-test-filtering.md) for details.
162162

163163
## Investigating PR validation failures
164164

@@ -167,7 +167,7 @@ Never hardcode the current TFM in a project. See
167167

168168
## Keeping AI context and docs in sync
169169

170-
Before completion, run the [`update-docs` skill](skills/update-docs/SKILL.md). It owns the
170+
Before completion, run the [`update-docs` skill](.github/skills/update-docs/SKILL.md). It owns the
171171
required checklist for memory, instructions, `AGENTS.md`, skills, agents, contributor
172172
documentation, help, snapshots, and localized resources.
173173

‎src/sdk/CODEOWNERS‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -109,10 +109,10 @@
109109
/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.ClickOnce.targets @sujitnayak
110110

111111
# Area-Watch
112-
/test/TestAssets/TestProjects/Watch*/ @tmat @dotnet/roslyn-ide
113-
/test/dotnet-watch.Tests/ @tmat @dotnet/roslyn-ide
112+
/test/TestAssets/TestProjects/Watch*/ @dotnet/hot-reload
113+
/test/dotnet-watch.Tests/ @dotnet/hot-reload
114114
/test/Microsoft.AspNetCore.Watch.BrowserRefresh.Tests/ @dotnet/aspnet-blazor-eng
115-
/src/Dotnet.Watch/ @tmat @dotnet/roslyn-ide
115+
/src/Dotnet.Watch/ @dotnet/hot-reload
116116
/src/Dotnet.Watch/BrowserRefresh @dotnet/aspnet-blazor-eng
117117
/src/Dotnet.Watch/AspireService @dotnet/aspnet-blazor-eng
118118

0 commit comments

Comments
 (0)