You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Commit 082832b
Browse filesBrowse the repository at this point in the historyBrowse files
Copy file name to clipboardExpand all lines: src/sdk/.github/memory/FILE_MAP.md
+3-1Lines changed: 3 additions & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -19,14 +19,16 @@ and [`CODEOWNERS`](../../CODEOWNERS) is the ownership source of truth.
19
19
|[`build/`](../../build)| Repository-specific build targets and generated-resource support. | Imported from root `Directory.Build.*`. |
20
20
|[`scripts/`](../../scripts)| Repository maintenance and evaluation utilities, including conditional-test selection. | Used by developers, agents, and CI. |
21
21
|[`documentation/`](../../documentation)| Contributor and subsystem documentation. Start with the [Developer Guide](../../documentation/project-docs/developer-guide.md). | Must remain synchronized with product and workflow changes. |
22
-
|[`.github/`](..)| GitHub workflows, agent instructions, agents, skills, and memory. | Guides GitHub automation and AI-assisted development. |
22
+
|[`.github/`](..)| GitHub workflows, agents, skills, and memory. | Guides GitHub automation and AI-assisted development. |
23
23
|[`.azuredevops/`](../../.azuredevops), [`eng/pipelines`](../../eng/pipelines)| Azure DevOps pipeline entry points and shared templates. | Build and submit tests to Helix. |
24
24
|[`benchmarks/`](../../benchmarks)| Performance benchmarks for selected components. | Consumes product projects; not part of routine targeted validation. |
25
25
|`.dotnet/`| Repository-local SDK restored by the build. Invoke `.dotnet/dotnet` (`.dotnet\dotnet.exe` on Windows) when a command should resolve with the repository bootstrap SDK. | Selected by [`global.json`](../../global.json); not a product output or the SDK exercised by product tests. |
26
26
|`artifacts/`| Generated build, package, log, test, and redist outputs; never source-controlled. | Recreated by builds. |
Copy file name to clipboardExpand all lines: src/sdk/.github/memory/TESTING_STRATEGY.md
+1-1Lines changed: 1 addition & 1 deletion
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -19,7 +19,7 @@ are colocated under
19
19
| Shared test harness |[`test/Microsoft.NET.TestFramework.MSTest`](../../test/Microsoft.NET.TestFramework.MSTest)|
20
20
| Configured PR test scopes and trigger paths |[`test/ConditionalTests.props`](../../test/ConditionalTests.props)|
21
21
| Conditional-filtering design and maintenance |[`pr-test-filtering.md`](../../documentation/project-docs/pr-test-filtering.md)|
22
-
| Full repository build and suite |[Root instructions](../copilot-instructions.md#build-and-test) and [Developer Guide](../../documentation/project-docs/developer-guide.md#running-tests)|
22
+
| Full repository build and suite |[Root instructions](../../AGENTS.md#build-and-test) and [Developer Guide](../../documentation/project-docs/developer-guide.md#running-tests)|
23
23
| Helix publishing and partitioning |[`test/UnitTests.proj`](../../test/UnitTests.proj)|
24
24
| Reproducing a Helix layout locally |[`repro-helix-failure.md`](../../documentation/project-docs/repro-helix-failure.md)|
Copy file name to clipboardExpand all lines: src/sdk/.github/skills/code-review/SKILL.md
+2-2Lines changed: 2 additions & 2 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -188,8 +188,8 @@ Only flag **actual problems**. Every comment must identify a concrete issue. Cat
188
188
12.**Missing error handling at system boundaries** — unvalidated external input or missing null checks at public/internal API entry points. Do NOT flag null checks for parameters the type system already guarantees non-null.
189
189
13.**Resource leaks** — `IDisposable` objects (e.g., `CancellationTokenSource`, `SemaphoreSlim`, process handles) created but never disposed, even if the pattern was moved from elsewhere.
190
190
14.**Documentation & explanatory comments for non-obvious SDK behavior** — subtle target/property decisions, runtime mapping, or cross-repo ownership boundaries that a future maintainer cannot infer from types or names and that lack a durable comment; stale comments that contradict the code; workaround comments without a tracking link.
191
-
15.**Repository convention violations** — the change breaks a rule documented in the [repository guardrails](../../copilot-instructions.md#guardrails) or the nearest area `AGENTS.md`. Read those files (they govern the directories being changed) and flag violations the build won't already catch — for example, hand-editing generated or regenerated files, or fixing behavior in this repo that another repo owns.
192
-
16. **Stale or ungrounded AI context / instructions / docs** — the change makes something an AI- or contributor-facing artifact says no longer true: a documented command, file path or location, guardrail, build/test workflow, convention, or architecture description that the change has invalidated (for example, moving or renaming a file that a doc references), and that artifact wasn't updated in the same PR. Also flag newly added or materially changed important claims about architecture, product behavior, or ownership when they lack a durable primary-source link (code or project files, an ADR or design document, or an issue or PR). Flag citations that do not support the claim and inferences presented as established facts. Name the exact artifact — `.github/copilot-instructions.md`, `.github/memory/*.md`, any `AGENTS.md` in an affected subdirectory, a `.github/skills/*/SKILL.md`, a `.claude/skills/*/SKILL.md`, a `.github/agents/*.agent.md`, or a file under `documentation/` — and the concrete drift or unsupported claim. Don't flag internal changes that no artifact describes, and don't demand citations for routine instructions or obvious code-local facts.
191
+
15.**Repository convention violations** — the change breaks a rule documented in the [repository guardrails](../../../AGENTS.md#guardrails) or the nearest area `AGENTS.md`. Read those files (they govern the directories being changed) and flag violations the build won't already catch — for example, hand-editing generated or regenerated files, or fixing behavior in this repo that another repo owns.
192
+
16. **Stale or ungrounded AI context / instructions / docs** — the change makes something an AI- or contributor-facing artifact says no longer true: a documented command, file path or location, guardrail, build/test workflow, convention, or architecture description that the change has invalidated (for example, moving or renaming a file that a doc references), and that artifact wasn't updated in the same PR. Also flag newly added or materially changed important claims about architecture, product behavior, or ownership when they lack a durable primary-source link (code or project files, an ADR or design document, or an issue or PR). Flag citations that do not support the claim and inferences presented as established facts. Name the exact artifact — the root or nearest area `AGENTS.md`, `.github/memory/*.md`, a `.github/skills/*/SKILL.md`, a `.claude/skills/*/SKILL.md`, a `.github/agents/*.agent.md`, or a file under `documentation/` — and the concrete drift or unsupported claim. Don't flag internal changes that no artifact describes, and don't demand citations for routine instructions or obvious code-local facts.
-**`.xlf` localization files.** Change the source `.resx` strings instead, then
108
108
regenerate the `.xlf` with the `/t:UpdateXlf` MSBuild target. Correctly regenerated
109
109
entries have a state of `needs-review-translation` or `new`. See
110
-
[Localization](../documentation/project-docs/Localization.md) for the full workflow.
110
+
[Localization](documentation/project-docs/Localization.md) for the full workflow.
111
111
-**Generated man pages** under `documentation/manpages/sdk`. These are generated from
112
112
documentation; change the upstream documentation in https://github.com/dotnet/docs instead.
0 commit comments