Skip to content

Conversation

@gewarren
Copy link
Contributor

@gewarren gewarren commented Nov 3, 2022

@dotnet-bot dotnet-bot added this to the November 2022 milestone Nov 3, 2022
@ghost ghost added the 🏁 Release: .NET 7 Work items for the .NET 7 release label Nov 3, 2022
@gewarren gewarren requested review from a team and steveharter November 3, 2022 19:19
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, once we resolve one inconsistency I noticed in the section names.

Then, let's :shipit:

@gewarren gewarren merged commit 039cbc7 into dotnet:main Nov 7, 2022
@gewarren gewarren deleted the diagnostics-config branch November 7, 2022 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏁 Release: .NET 7 Work items for the .NET 7 release dotnet-fundamentals/svc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Breaking change]: app.config cannot have a <section name="system.diagnostics" entry

4 participants