Fix issue - #31462 - Observations in maui-ebook #32111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
community-contribution
IEvangelist
reviewed
Nov 2, 2022
Member
IEvangelist
left a comment
IEvangelist
left a comment
There was a problem hiding this comment.
This looks good to me, thank you @erjain. What more do you plan on updating?
Contributor
Author
Hi @IEvangelist, thanks for reviewing, I am waiting on PR dotnet-architecture/eshop-mobile-client#31. If you think, we are good to merge this PR, then please go ahead, I have made it ready to review. |
IEvangelist
approved these changes
Nov 4, 2022
Member
IEvangelist
left a comment
IEvangelist
left a comment
There was a problem hiding this comment.
Looks good to me, we'll 
- thank you 🙏
CamSoper
pushed a commit
that referenced
this pull request
Nov 4, 2022
* fixes #21591 (#32186) * fixes #21591 * update file path Co-authored-by: Tarun Jain <[email protected]> * fixes #31983 (#32157) * fixes #31983 * Update docs/architecture/modern-web-apps-azure/work-with-data-in-asp-net-core-apps.md Co-authored-by: David Pine <[email protected]> Co-authored-by: Tarun Jain <[email protected]> Co-authored-by: David Pine <[email protected]> * Fix issue - #31462 - Observations in maui-ebook (#32111) Co-authored-by: Tarun Jain <[email protected]> * fixes #31985 (#32156) * fixes #31985 * Update docs/architecture/modern-web-apps-azure/work-with-data-in-asp-net-core-apps.md Co-authored-by: David Pine <[email protected]> Co-authored-by: Tarun Jain <[email protected]> Co-authored-by: David Pine <[email protected]> * Update quest.yml (#32188) * Update quest.yml (#32189) * Add a note regarding supressing CS0282 (#32170) Dotnet provides the means to inhibit this message, but it was not clear from the warning documentation how to properly supress the warning and express intent that the layout of the struct was not significant * Add defaultconstraint_CSharpKeyword (#32184) * Update quest.yml (#32190) * Update quest.yml * Update quest.yml * Update using-properties.md (#32185) * Create quest-bulk.yml (#32192) * -r changed from --results-directory to --runtime in .NET 7 (#32163) * Revive Point of Service docs from the dead (#32079) * initial commit * Fix indent * better paths * little tweaks * fix link * Update docs/framework/additional-apis/index.md Co-authored-by: David Pine <[email protected]> * initial conversion * tables tables tables * markdownlint pass * missed one * another pass * xrefs, part 1 * Revert "xrefs, part 1" This reverts commit 22185ae. * Populated all the xrefs * images * API reference link * fix toc * add descriptions * Removed extra newlines * Fixed table warnings * fix metadata * Made all the "see alsos" bulleted lists * v1.12->v1.14 Co-authored-by: David Pine <[email protected]> * Update quest.yml (#32199) * Update quest-bulk.yml (#32202) * Update quest-bulk.yml * Update quest-bulk.yml Try `-1` instead. * Update quest-bulk.yml * Added missing link for actors.md (#32201) * Legacy FileStream mode and symlink breaking changes (#31602) Co-authored-by: Tarun Jain <[email protected]> Co-authored-by: Tarun Jain <[email protected]> Co-authored-by: David Pine <[email protected]> Co-authored-by: Ashleigh Adams <[email protected]> Co-authored-by: Youssef Victor <[email protected]> Co-authored-by: Eli Entelis <[email protected]> Co-authored-by: Tom Dykstra <[email protected]> Co-authored-by: Henrik Schönfelder <[email protected]> Co-authored-by: Genevieve Warren <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #31462