Add note on suppressing trimming warnings #30239
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inspired by the suppression justification from dotnet/linker#2891.
vitek-karas
approved these changes
Jul 15, 2022
Member
vitek-karas
left a comment
vitek-karas
left a comment
There was a problem hiding this comment.
Thanks a lot!
I'm still terrible at thinking about trimming the right way - I think what the linker does today, not what it "Should do" in theory.
Member
Author
The more aggressive constant propagation in .NET 7 already puts the IL linker into these territories today. It doesn't kick in often, but when it does, statically used properties and methods get removed. |
eerhardt
reviewed
Jul 15, 2022
eerhardt
approved these changes
Jul 15, 2022
Co-authored-by: Eric Erhardt <[email protected]> Co-authored-by: Sven Boemer <[email protected]>
Member
Author
|
@adegeo is this okay to merge? |
IEvangelist
approved these changes
Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inspired by the suppression justification from dotnet/linker#2891.
Cc @vitek-karas @sbomer @tlakollo @eerhardt