OSPlatform attributes breaking change #20659
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffhandley
approved these changes
Sep 16, 2020
Member
jeffhandley
left a comment
jeffhandley
left a comment
There was a problem hiding this comment.
This is great! Thanks for doctoring up what I wrote to make it much nicer!
Contributor
Author
You wrote it up beautifully. I hardly had to change anything! |
BillWagner
approved these changes
Sep 16, 2020
Member
BillWagner
left a comment
BillWagner
left a comment
There was a problem hiding this comment.
This also LGTM @gewarren. I did have one question.
Once the dependencies are merged, you can 
Contributor
Author
|
Close/reopen for fresh build. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20635.
Preview link.
(The warnings will go away once we merge the RC1 API doc updates.)