chore: Change output html file encoding to UTF-8 (No BOM)#9131
Merged
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #9131 +/- ##
=======================================
Coverage 77.58% 77.58%
=======================================
Files 591 591
Lines 24567 24568 +1
=======================================
+ Hits 19060 19061 +1
Misses 5507 5507
☔ View full report in Codecov by Sentry. |
What's the meta tag? I don't see it in the description. |
Collaborator
Author
Sorry it indicate |
yufeih
added
the
bug-fix
p-kostov
pushed a commit
to ErpNetDocs/docfx
that referenced
this pull request
Jun 28, 2024
chore: change output html file encoding to UTF-8 (No BOM)
p-kostov
pushed a commit
to ErpNetDocs/docfx
that referenced
this pull request
Jun 28, 2024
…tnet#9131)" This reverts commit 505f7cf. Fixes dotnet#9171
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's included in this PR
Background
Currently docfx output HTML files using UTF-8 (with BOM) encoding.
And other non-HTML files are using UTF-8 (No BOM).
Currently docfx output HTML with following meta tag. so it seems BOM is not required.
If there is any reason to use
UTF-8(BOM)close this PR.(For example. Snapshot tests library requires BOM)