Skip to content

Conversation

@rbuckton
Copy link

@rbuckton rbuckton commented Sep 23, 2019

This PR makes a few changes to the default template to fix some issues and better support TypeScript documentation. This PR is also intended to align with the changes to the @microsoft/api-documenter package in microsoft/rushstack#1537.

  • Add TypeScript namespaces, type aliases, and exported variables to the default template:
    image
  • Fixes Inheritance hierarchy rendering:
    image
  • Adds entries for the current TypeScript namespace (if one was recorded), and the containing package:
    image
Microsoft Reviewers: Open in CodeFlow

@dnfclas
Copy link

dnfclas commented Sep 23, 2019

CLA assistant check
All CLA requirements met.

@octogonz
Copy link

Awesome, thanks for making this PR! We've been waiting for this DocFX improvement for a long time.

@octogonz
Copy link

@AlexJerabek FYI

@octogonz
Copy link

@dend @OsmondJiang @yufeih

I noticed the v2 tag. Just curious, what's the usual timeframe for releasing a template update?

For some context, DocFX's handling of TypeScript namespaces has been an issue for libraries like Office Add-ins and Office UI Fabric for a long time. This PR is the second-to-last in a series of PRs that @rbuckton has been working on over the summer, which should finally solve this problem. We're really excited about it! But we can't merge microsoft/rushstack#1537 until the fixed template has been released.

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍👍

@octogonz , you mentioned this is the second-to-last PR, once all the PRs are merged, we can release an update of docfx. Release train ships every 3 weeks or so.

@octogonz
Copy link

you mentioned this is the second-to-last PR, once all the PRs are merged, we can release an update of docfx. Release train ships every 3 weeks or so.

The other PRs aren't for the DocFX project. They are for API Extractor, which is the tool that Office uses to generate the .yml input files for DocFX. The last PR microsoft/rushstack#1537 will update API Extractor to generate .yml files for namespaces, which requires the updated template from this PR. (Thus it is blocked until this PR gets merged+released.) Sorry, I guess I could have explained that better. 😊

@yufeih yufeih merged commit b026bb8 into dotnet:dev Sep 26, 2019
@yufeih
Copy link
Contributor

yufeih commented Sep 26, 2019

@octogonz that make sense.

@rbuckton
Copy link
Author

@yufeih Does the DocFX project publish nightly builds?

@yufeih
Copy link
Contributor

yufeih commented Sep 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants