Skip to content

feat: Use PlantUML Online Server as default configs#10395

Merged
yufeih merged 1 commit intodotnet:mainfrom
filzrev:chore-change-plantuml-config-defaults
Nov 18, 2024
Merged

feat: Use PlantUML Online Server as default configs#10395
yufeih merged 1 commit intodotnet:mainfrom
filzrev:chore-change-plantuml-config-defaults

Conversation

@filzrev
Copy link
Collaborator

@filzrev filzrev commented Nov 17, 2024

This PR change PlantUmlOptions default settings.

Background
When using PlantUML diagrams.
It need to explicitly set build/markdownEngineProperties/plantuml configs.
https://dotnet.github.io/docfx/docs/markdown.html#settings

Currently when above config is not defined. following exception is thrown.

error PlantUmlExtension: Value cannot be null. (Parameter 'uriString')

This PR change default settings to use PlantUML Online server as default options.

Copy link
Contributor

@yufeih yufeih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@yufeih yufeih added the new-feature Makes the pull request to appear in "New Features" section of the next release note label Nov 18, 2024
@yufeih yufeih changed the title chore: Use PlantUML Online Server as default configs feat: Use PlantUML Online Server as default configs Nov 18, 2024
@yufeih yufeih merged commit f35a47a into dotnet:main Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new-feature Makes the pull request to appear in "New Features" section of the next release note

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants