Updating project to use .NET 8#99
Merged
missymessa merged 4 commits intomainfrom Apr 30, 2025
Merged
Conversation
Contributor
|
You could theoretically use FakeTimeProvider and remove our weird test one if you wanted, but otherwise LGTM |
garath
reviewed
Apr 30, 2025
Member
garath
left a comment
garath
left a comment
There was a problem hiding this comment.
Looks good. I'm assuming all downstream projects are net8-ready.
garath
previously approved these changes
Apr 30, 2025
Member
|
Actually, should this also adopt Arcade's net8 branch too? Line 16 in 8249eb9 |
Member
Author
Oh, good catch. Let me update that. Any downstream project will have a PR and that PR will break if it's not able to take this in. In that event, I'll fix up the repo to accept the PR. |
meghnave
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dotnet/dnceng#1430