Synchronize GCInfoDecoder and GCInfoDumper with dotnet/runtime#5672
Merged
jkotas merged 1 commit intodotnet:mainfrom Dec 22, 2025
Merged
Synchronize GCInfoDecoder and GCInfoDumper with dotnet/runtime#5672jkotas merged 1 commit intodotnet:mainfrom
jkotas merged 1 commit intodotnet:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR synchronizes the GCInfoDecoder and GCInfoDumper implementations with the dotnet/runtime repository, incorporating format version improvements and cross-platform enhancements.
Key Changes:
- Updated safe point offset handling to only apply -1 adjustment for version < 4 formats
- Added support for RISC-V compressed instructions (2-byte) in addition to standard 4-byte instructions
- Added WebAssembly (TARGET_WASM) target support with interpreter-based GC info encoding
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/shared/vm/gcinfodecoder.cpp | Refactored interruptibility logic, deduplicated IsScratchStackSlot implementations across platforms, updated PSP_SYM to only decode for version < 4, added FEATURE_INTERPRETER support, and fixed template instantiations for WASM |
| src/shared/inc/gcinfotypes.h | Removed unused IsValidReturnRegister function, updated RISCV64 instruction normalization from 4-byte to 2-byte granularity, added TARGET_WASM configuration, and reorganized conditional compilation blocks |
| src/shared/inc/gcinfodecoder.h | Added comments marking PSP_SYM flags as unused in v4+, changed __forceinline to FORCEINLINE for portability, added HasStackBaseRegister method, and added InterpreterGcInfoDecoder typedef |
| src/shared/inc/gcdecoder.cpp | Fixed revPInvokeOffset to use proper XOR operation instead of incorrect ternary operator |
| src/shared/gcinfo/gcinfodumper.cpp | Updated safe point offset handling to conditionally increment based on version < 4 check |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lateralusX
approved these changes
Dec 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The makes !gcinfo work correctly against current main