Sync eng/native from dotnet/runtime #4178
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
am11
commented
Aug 22, 2023
am11
commented
- Sync eng/native with runtime
- Includes changes from Delete duplicate init-distro-rid.sh runtime#90952
- Since diagnostics is using newest arcade, reacted to Remove unused argument from initDistroRidGlobal arcade#13961 in second commit
Member
Author
|
cc @elinor-fung, @jkoritzinsky last sync was 56d6c65 (in the future, we can start moving more common parts upstream for complete de-duplication) |
mikem8361
reviewed
Aug 22, 2023
am11
force-pushed
the
feature/native/build
branch
from
86d30ba to
d1d6522
Compare
Member
Author
|
@mikem8361, PTAL. Once we sync PAL with runtime, we can revert the last commit (1fb94fc). The checks which were there to support printf were deleted after the removal of PAL's printf implementation in runtime. Other than that, eng/native is in sync. 🙏 |
mikem8361
approved these changes
Aug 23, 2023
hoyosjs
approved these changes
Aug 24, 2023
| <SOSPath>$(InstallDir)/libsosplugin.so</SOSPath> | ||
| </Option> | ||
| <Option Condition="$(OS) == OSX"> | ||
| <Option Condition="'$(OS)' == 'osx'"> |
Member
There was a problem hiding this comment.
This isn't msbuild, though the parser should handle it OK
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.