Adds skipping non-matching URLs in OpenAITelemetryPlugin#1206
Merged
waldekmastykarz merged 1 commit intodotnet:mainfrom May 22, 2025
Merged
Adds skipping non-matching URLs in OpenAITelemetryPlugin#1206waldekmastykarz merged 1 commit intodotnet:mainfrom
waldekmastykarz merged 1 commit intodotnet:mainfrom
Conversation
Collaborator
waldekmastykarz
commented
May 22, 2025
waldekmastykarz
commented
- Adds skipping non-matching URLs in OpenAITelemetryPlugin
- Changes the order of checks in OpenAIMockResponsePlugin so that checking for matching URLs is done first, which makes more sense.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the URL matching logic to skip non-matching URLs in the telemetry and mock response plugins, and reorders the checks in the mock response plugin for improved logical consistency.
- Prioritize URL matching before checking if a response is already set in OpenAIMockResponsePlugin.
- Add URL matching logic to OpenAITelemetryPlugin for early bailout on non-matching requests.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| dev-proxy-plugins/Mocks/OpenAIMockResponsePlugin.cs | Reorders the condition checks to perform URL matching before checking if the response has been set. |
| dev-proxy-plugins/Inspection/OpenAITelemetryPlugin.cs | Introduces URL matching logic to skip processing when the request URL does not match. |
waldekmastykarz
force-pushed
the
fix-openaiotel-response
branch
from
ba6e2e9 to
867122e
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR ensures that both the telemetry and mock response plugins skip processing when a request’s URL doesn’t match the configured list, and it reorders checks in the mock plugin to first verify the URL before checking if a response is already set.
- Added a URL-match guard in
OpenAITelemetryPluginto early-return on non-matching URLs. - Reordered the
ifconditions inOpenAIMockResponsePluginso URL matching is checked beforeResponseState.HasBeenSet. - Updated skipped log messages to reflect the new check order.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| dev-proxy-plugins/Mocks/OpenAIMockResponsePlugin.cs | Swapped the order of URL-match and response-set checks; updated corresponding log messages. |
| dev-proxy-plugins/Inspection/OpenAITelemetryPlugin.cs | Introduced an early-return guard for non-matching URLs in OnRequestAsync. |
Comments suppressed due to low confidence (2)
dev-proxy-plugins/Inspection/OpenAITelemetryPlugin.cs:139
- Consider adding unit tests that verify telemetry is correctly skipped when URLs do not match, and that it proceeds when they do.
if (UrlsToWatch is null || !e.HasRequestUrlMatch(UrlsToWatch))
dev-proxy-plugins/Mocks/OpenAIMockResponsePlugin.cs:38
- Replacing the original
e.ShouldExecute(UrlsToWatch)withe.HasRequestUrlMatch(...)may omit additional checks thatShouldExecuteperformed. Verify that no other execution conditions (e.g., HTTP method or headers) are lost, or consolidate into a single guard method.
!e.HasRequestUrlMatch(UrlsToWatch)
garrytrinder
approved these changes
May 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.